1051746 - [MobileID] Get the proper ICC info

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

https://bugzilla.mozilla.org/show_bug.cgi?id=988469#c68

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Sorry, this one got out of my radar for a while :(...

[Blocking Requested - why for this release]: Without this fix in a multi-SIM scenario we may share the incorrect phone number with the consumer of the Mobile ID API. I think this needs to go on 2.0 because this breaks the Mobile ID feature sharing an incorrect number and it violates the user's privacy cause the user does not explicitly select the phone number that we share but other one.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Sam, this patch makes sure that we have the proper ICC information at all times.

We were not listening for the iccinfochange event and so our cache could be obsolete if any change on the ICC status occurred. Now we are listening for these event and clearing the caches when needed.

Comment 5

[Sam Penrose]

Comment on attachment 8492969 [details] [diff] [review]
v1

Fernando -- the code looks good as best I can tell. I was not able to execute the new unit test because MOZ_B2G_RIL is not set for me, but I think that is an artifact of overriding the platform to get xpcshell to run. So r+, thanks!

Comment 6

[Rachelle Yang [:ryang][[e-mail]]]

Hi Bhavana, could you please kindly help triage 2.0? on this ? Thank you very much.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5f470ac9f032

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5f470ac9f032

Comment 9

[Andrew Overholt [:overholt]]

Broken new feature = 2.0+.  Will this get uplifted automatically?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Needs b2g32 and aurora approvals for uplift.

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8492969 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: Mobile ID
[User impact if declined]:  Without this fix in a multi-SIM scenario we may share the incorrect phone number with the consumer of the Mobile ID API. I think this needs to go on 2.0 because this breaks the Mobile ID feature sharing an incorrect number and it violates the user's privacy cause the user does not explicitly select the phone number that we share but other one.
[Describe test coverage new/current, TBPL]: Unit tests added to the already existing ones.
[Risks and why]: Low risk. The only consumer of this feature is being developed by the same team, so any regression should be catch and fixed pretty soon.
[String/UUID change made/needed]: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/387913293852
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/d9dc5c830234

Comment 13

[Kai-Zhen Li [:seinlin][:kli]]

http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/d9dc5c830234