1051872 - media GMP addon gets installed during jetpack test run..

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Tomislav Jovanovic :zombie]

i think it's the new addon for doing DRM stuff..

this is how :gfritzsche says we should disable it:

http://mxr.mozilla.org/mozilla-central/search?string=%2Fdummy.xml&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 1

[Georg Fritzsche [:gfritzsche]]

GMP is the GeckoMediaPlugins, which are now used for OpenH264 (and later for EME and other things):
https://wiki.mozilla.org/GeckoMediaPlugins

Comment 2

[Dave Townsend [:mossop]]

Should be solved by bug 1035512 I think

Comment 3

[Dave Townsend [:mossop]]

So bug 1030036 apparently did this, but we still see a lot of promise rejection failures from GMPInstallManager.

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch

This disabled attempts to update the GMP plugin solving most of the promise rejection failures in our tests.

Comment 5

[Tomislav Jovanovic :zombie]

(In reply to Dave Townsend [:mossop] from comment #3)
> So bug 1030036 apparently did this, but we still see a lot of promise
> rejection failures from GMPInstallManager.

that just disabled the outbound update request, but now the install check fails and browser.js doesn't handle the Promise rejection:

http://dxr.mozilla.org/mozilla-central/source/toolkit/modules/GMPInstallManager.jsm#477
http://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1343

Comment 6

[Tomislav Jovanovic :zombie]

Comment on attachment 8473797 [details] [review]
patch

just tracked down the exact same thing, so i can r+..

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/97d98bbd18b6a8824f2613428fbfcd7be46cf349
Bug 1051872: Disable GMP auto updates.

https://github.com/mozilla/addon-sdk/commit/b632537d8782b2f55c915d7cf5f4760bb6d12c5e
Merge pull request #1588 from Mossop/bug1051872

Bug 1051872: Disable GMP auto updates. r=zombie