1030036 - Jetpack needs to define MOZ_DISABLE_NONLOCAL_CONNECTIONS

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Ed Morley [:emorley]]

Jetpack doesn't currently define MOZ_DISABLE_NONLOCAL_CONNECTIONS (added by bug 995417) during automation runs, so we aren't protecting ourselves against non-loopback connections (eg external resource outside of the build network).

We need to:
a) Fix any failures caused by pre-existing bad behaviour (much of this will just be ensuring the automation prefs for disabling things like safebrowsing etc are set; see bug 1023483 comment 0 for what other suites use).
b) Start defining it during our automation test runs once we're green from (a).

Comment 1

[Ed Morley [:emorley]]

This try run shows what will fail when we define MOZ_DISABLE_NONLOCAL_CONNECTIONS:
https://tbpl.mozilla.org/?tree=Try&rev=b6d1d8e8b633&jobname=jetpack

Note that the jobs aren't turning orange (yet, since I disabled the crash, so we could catch multiple instances per test run, rather than aborting early), so you have to look at the logs.

In every jetpack run, we're making external connections

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=42430325&tree=Try
Ubuntu VM 12.04 try opt test jetpack on 2014-06-25 02:40:32 PDT for push b6d1d8e8b633
{
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to safebrowsing.google.com (74.125.239.96) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to clients1.google.com (74.125.239.103) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to safebrowsing-cache.google.com (74.125.239.104) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to incoming.telemetry.mozilla.org (54.244.245.104) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to ocsp.digicert.com (72.21.91.29) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to safebrowsing.google.com (173.194.67.190) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to clients1.google.com (74.125.239.104) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to safebrowsing-cache.google.com (74.125.239.110) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to safebrowsing.google.com (173.194.67.93) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to clients1.google.com (74.125.239.98) was made.
TEST-UNEXPECTED-FAIL | Non-local network connections are disabled and a connection attempt to safebrowsing-cache.google.com (74.125.239.99) was made.
}

I'll file dependant bug(s) for fixing these.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1583

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/29e0649fd6cf5d4a0cabbe936b677fdcb7ee84d9
Bug 1030036 - Jetpack needs to define MOZ_DISABLE_NONLOCAL_CONNECTIONS

https://github.com/mozilla/addon-sdk/commit/ded315e24210ec449b092ae60baede9821c72c5d
Merge pull request #1583 from erikvold/1030036

Bug 1030036 - Jetpack needs to define MOZ_DISABLE_NONLOCAL_CONNECTIONS r=@Mossop

Comment 4

[Ed Morley [:emorley]]

Thank you for sorting this :-)