Closed Bug 1052047 Opened 10 years ago Closed 10 years ago

No "Review needed?" section when creating a subpage

Categories

(developer.mozilla.org Graveyard :: Editing, defect)

All
Other
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: djthrottle, Unassigned, Mentored)

Details

(Whiteboard: [specification][type:bug])

What did you do?
================
1. Open a page on MDN (e.g. https://developer.mozilla.org/en-US/docs/Glossary/JavaScript)
2. Go over the "gear" menu and click on the "New sub-page" link
3. On the editor page, go to the bottom

What happened?
==============
There's no "Review needed?" section

What should have happened?
==========================
There should be a "Review needed?" section

Is there anything else we should know?
======================================
The same happens when you follow a red link that takes you to the "New document" page.
The Review needed section: 

Review needed?

    Technical - code samples, APIs, or technologies
    Editorial - prose, grammar, or content
    Template - KumaScript code


is missing from the bottom of page when someone creates a brand-new article. I'm pretty usre it usd to be there, and is really important for new articles as many times they need review.
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: General → Editing
If someone can mentor me (and if this is not urgent) I'd like to try my hand at this as my first bug.
Federico - I'm happy to mentor you. Would you like to start by setting up MDN in a local development VM using vagrant?

http://kuma.readthedocs.org/en/latest/installation-vagrant.html
Mentor: lcrouch
Thanks luke. I already set up the environment and also tried to fix this. The only problem is the checkboxes are pre-checked and there's no "template review" checkbox. Am I on the right track?
Federico, right - we removed the template review [1] last week per bug 1040599.

:sheppy - as I understand it, the review boxes *should* be pre-checked for new pages, right?

[1] https://github.com/mozilla/kuma/pull/2650
Flags: needinfo?(eshepherd)
ok, as soon as I get home (in a couple hours) I'll try to do a pull request
Pull request done, waiting for review
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/66a94cfe7c14ffd64909e37254d1808c204514b1
fix bug 1052047 - Restored "Review needed" section upon creating a page

https://github.com/mozilla/kuma/commit/bc8845932ad4d8c07c7d7aadf2504f0b40d127fa
fix bug 1052047 - test the review section is on the page

https://github.com/mozilla/kuma/commit/b352f423a865ed63821b0d139241076187b0d47b
Merge pull request #2689 from groovecoder/new-doc-review-block-1052047

fix bug 1052047 - New doc review block
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This is fixed so no needinfo on me anymore.
Flags: needinfo?(eshepherd)
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.