1052246 - [Text Selection] Position of utility bubble is wrong in b2g desktop

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Utility bubbles are not shown in b2g desktop. After some debugging, I found that the position of bubbles are always wrong.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1052246

I found 2 problems cause this bug.

1. In b2g-desktop, mozInnerScreen is "actual" window position. So that we will get incorrect value in b2g-desktop. So I subtract "window.mozInnerScreen" to get the correct window offset.

2. Since shell.js handle the offsets of <iframe mozbrowser> boundary [1], we shouldn't add <iframe mozbrowser> offsets to rect in BrowserElementChildPreload.js [2]. So I modified it to not cross <iframe mozbrowser> boundary.

After those 2 modifications, utility bubbles show correctly.

[1]: http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/shell.js#524
[2]: http://dxr.mozilla.org/mozilla-central/source/dom/browser-element/BrowserElementChildPreload.js#651

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8471321 [details] [diff] [review]
bug1052246

Review of attachment 8471321 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense, thanks!

::: dom/browser-element/BrowserElementChildPreload.js
@@ +643,5 @@
>        reasons: e.reasons,
>        isCollapsed: (e.selectedText.length == 0),
>      };
>  
> +    // Get correct geometry information if we have nested iframe

nit: full stop at the end of comment.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1052246 v2 (carry r+: fabrice)

fix nit.

try run: https://tbpl.mozilla.org/?tree=Try&rev=7d69227252bd

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1052246 v3 (carry r+: fabrice)

Rebased.

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

oops uploaded wrong patch...

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1052246 v4 (carry r+: fabrice)

Upload correct patch.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3723f4d7eab5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3723f4d7eab5