1052371 - ShutdownLeaks detector is deactivated and runs for mochitests other than bc

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Those are regressions from bug 886570.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1052371-Fix-m-bc-shutdown-leak-detector.patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=ac9f5bfcb788

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1052371-Fix-m-bc-shutdown-leak-detector.patch, v2

Sorry.

https://tbpl.mozilla.org/?tree=Try&rev=f4b7fe55d07e

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

The one leak we see so far is reproducible locally for me:

toolkit/mozapps/extensions/test/browser/browser_openH264.js | leaked 2 window(s) until shutdown [url = about:addons]

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Try push with a fix for bug 1052409:

https://tbpl.mozilla.org/?tree=Try&rev=e1d01b882103

Comment 6

[Ahmed Kachkach [:akachkach]]

Comment on attachment 8471520 [details] [diff] [review]
0001-Bug-1052371-Fix-m-bc-shutdown-leak-detector.patch, v2

Review of attachment 8471520 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! The "suite_end" part is probably due to the fact that we don't process the messages generated through Python by those handlers (and that was previously generated by the JS side).
I went ahead and checked that "TEST-START | Shutdown" is still printed by mochitest-plain, mochitest-chrome and robocop.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/d04a9bf0df24

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Oops, Android mochitests were failing. Pushed a tiny bustage fix:

https://hg.mozilla.org/integration/fx-team/rev/9b26ce378971

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Had to back out unfortunately. DevTools tests leak the world :(

https://hg.mozilla.org/integration/fx-team/rev/e5249cb294a8
https://hg.mozilla.org/integration/fx-team/rev/a60a276fb205

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

Here is a leak log:

https://tbpl.mozilla.org/php/getParsedLog.php?id=45772397&tree=Fx-Team

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

New try push with the patch from bug 1052756:

https://tbpl.mozilla.org/?tree=Try&rev=469635719a6b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c865443dfb0c

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/540ac322aac8