Closed Bug 1052756 Opened 10 years ago Closed 10 years ago

Add-on debugger tests leak toolbox and debugger frames

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox33 unaffected, firefox34 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 34
Tracking Flags:
Tracking Status
firefox33 --- unaffected
firefox34 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Keywords: reproducible)

Attachments

(1 file)

0002-Bug-1052756-Fix-Toolbox.destroy-to-properly-clean-up.patch
1.19 KB, patch
mossop
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=45772397&tree=Fx-Team#error0 TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-console.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-console.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-console.js | leaked 1 window(s) until shutdown [url = about:blank] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules-unpacked.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules-unpacked.js | leaked 1 window(s) until shutdown [url = about:blank] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules-unpacked.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules.js | leaked 1 window(s) until shutdown [url = about:blank] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-panels.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-panels.js | leaked 1 window(s) until shutdown [url = about:blank] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-panels.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-sources.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-sources.js | leaked 1 window(s) until shutdown [url = about:blank] TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-sources.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul]
It seems that due to bug 1052371 we didn't detect those leaks when the feature landed.
Dave, any idea what's happening here? Reproducible locally with a debug build and the patch from bug 1052371 applied.
Flags: needinfo?(dtownsend+bugmail)
Keywords: reproducible
All of the tests calling initAddonDebugger() seem to be affected.
Specifically? No. At a guess something is keeping a reference to the frame we load the devtools into. It's strange though, there were some leaks reported when I was landing that code which we fixed. It'll be a couple of days before I get chance to look into this unless it is more urgent?
Flags: needinfo?(dtownsend+bugmail)
Toolbox.destroy() fails because _pickerButton is only built for non-addon targets. Doesn't leak locally anymore with that fixed.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8472317 - Flags: review?(dtownsend+bugmail)
Comment on attachment 8472317 [details] [diff] [review] 0002-Bug-1052756-Fix-Toolbox.destroy-to-properly-clean-up.patch Review of attachment 8472317 [details] [diff] [review]: ----------------------------------------------------------------- Wonderful! Thanks Tim.
Attachment #8472317 - Flags: review?(dtownsend+bugmail) → review+
https://hg.mozilla.org/mozilla-central/rev/aabd9acf3c28
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
IIUC, this was a regression from bug 1030318, which only landed on 34.
status-firefox33: --- → unaffected
status-firefox34: --- → fixed
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: