1052756 - Add-on debugger tests leak toolbox and debugger frames

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=45772397&tree=Fx-Team#error0

TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-console.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-console.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-console.js | leaked 1 window(s) until shutdown [url = about:blank]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules-unpacked.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules-unpacked.js | leaked 1 window(s) until shutdown [url = about:blank]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules-unpacked.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-modules.js | leaked 1 window(s) until shutdown [url = about:blank]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-panels.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-panels.js | leaked 1 window(s) until shutdown [url = about:blank]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-panels.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-sources.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-sources.js | leaked 1 window(s) until shutdown [url = about:blank]
TEST-UNEXPECTED-FAIL | browser/devtools/debugger/test/browser_dbg_addon-sources.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/debugger.xul]

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

It seems that due to bug 1052371 we didn't detect those leaks when the feature landed.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Dave, any idea what's happening here? Reproducible locally with a debug build and the patch from bug 1052371 applied.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

All of the tests calling initAddonDebugger() seem to be affected.

Comment 4

[Dave Townsend [:mossop]]

Specifically? No. At a guess something is keeping a reference to the frame we load the devtools into. It's strange though, there were some leaks reported when I was landing that code which we fixed.

It'll be a couple of days before I get chance to look into this unless it is more urgent?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0002-Bug-1052756-Fix-Toolbox.destroy-to-properly-clean-up.patch

Toolbox.destroy() fails because _pickerButton is only built for non-addon targets. Doesn't leak locally anymore with that fixed.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=469635719a6b

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8472317 [details] [diff] [review]
0002-Bug-1052756-Fix-Toolbox.destroy-to-properly-clean-up.patch

Review of attachment 8472317 [details] [diff] [review]:
-----------------------------------------------------------------

Wonderful! Thanks Tim.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aabd9acf3c28

Comment 9

[Ryan VanderMeulen [:RyanVM]]

IIUC, this was a regression from bug 1030318, which only landed on 34.