1052852 - Use enums for contactType in MozIcc.webidl and nsIIccProvider.idl

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Anshul]

Just like it's done in bug 937485 I would like to request to use the enums for contact type for the following APIs in both the WebIDL and IPDL interface.

- readContacts
- updateContact

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Included in my https://github.com/vicamo/b2g_mozilla-central/tree/bugzilla/864489/icc-ipdl WIP branch for bug 864489. Maybe resolved in that bug, maybe move the related parts here to be more clear & simple. Let's see.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Comment 4

[Edgar Chen [:edgar]]

Attachment: Patch, v3

Comment 5

[Edgar Chen [:edgar]]

Attachment: Patch, v4

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8537105 [details] [diff] [review]
Patch, v4

Review of attachment 8537105 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Hsinyi, may I have your review? Thank you.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8537105 [details] [diff] [review]
Patch, v4

Review of attachment 8537105 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you ~~

Comment 8

[Edgar Chen [:edgar]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=00ff6d1e1b5d

Comment 9

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d16461a97b4f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d16461a97b4f