Closed Bug 1052852 Opened 9 years ago Closed 9 years ago

Use enums for contactType in MozIcc.webidl and nsIIccProvider.idl

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.2+, tracking-b2g:backlog)

Status:
RESOLVED FIXED
Milestone:
2.2 S2 (19dec)
Project Flags:
feature-b2g 2.2+
tracking-b2g backlog

People

(Reporter: anshulj, Assigned: edgar)

References

Details

(Whiteboard: [priority1])

Attachments

(1 file, 3 obsolete files)

Patch, v4
29.17 KB, patch
hsinyi
: review+
Details | Diff | Splinter Review 
Just like it's done in bug 937485 I would like to request to use the enums for contact type for the following APIs in both the WebIDL and IPDL interface.

- readContacts
- updateContact
Blocks: 1058305
Blocks: 1058308
No longer blocks: 1058305
Included in my https://github.com/vicamo/b2g_mozilla-central/tree/bugzilla/864489/icc-ipdl WIP branch for bug 864489. Maybe resolved in that bug, maybe move the related parts here to be more clear & simple. Let's see.
No longer blocks: 1058308
Assignee: nobody → echen
Blocks: 864489, b2g-ril-interface
blocking-b2g: --- → backlog
feature-b2g: --- → 2.2+
Whiteboard: [priority1]
Target Milestone: --- → 2.2 S2 (19dec)
Attached patch Patch, v1 (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch, v2 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #8535522 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch, v3 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #8535529 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch, v4
        — 
          — Splinter Review
      

    


  

        Attachment #8537046 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8537105 [details] [diff] [review]
Patch, v4

Review of attachment 8537105 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Hsinyi, may I have your review? Thank you.

        Attachment #8537105 -
        Flags: review?(htsai)

    
    

    
  
Comment on attachment 8537105 [details] [diff] [review]
Patch, v4

Review of attachment 8537105 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you ~~

        Attachment #8537105 -
        Flags: review?(htsai) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d16461a97b4f
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
blocking-b2g: backlog → ---

          tracking-b2g:
          --- → backlog

    
  
Blocks: 1157082

          You need to log in
          before you can comment on or make changes to this bug.