Use enums for contactType in MozIcc.webidl and nsIIccProvider.idl

RESOLVED FIXED in 2.2 S2 (19dec)

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: anshulj, Assigned: edgar)

Tracking

unspecified
2.2 S2 (19dec)
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(feature-b2g:2.2+, tracking-b2g:backlog)

Details

(Whiteboard: [priority1])

Attachments

(1 attachment, 3 obsolete attachments)

Reporter

Description

5 years ago
Just like it's done in bug 937485 I would like to request to use the enums for contact type for the following APIs in both the WebIDL and IPDL interface.

- readContacts
- updateContact

Updated

5 years ago
Blocks: 1058305

Updated

5 years ago
Blocks: 1058308
Reporter

Updated

5 years ago
No longer blocks: 1058305
Included in my https://github.com/vicamo/b2g_mozilla-central/tree/bugzilla/864489/icc-ipdl WIP branch for bug 864489. Maybe resolved in that bug, maybe move the related parts here to be more clear & simple. Let's see.
No longer blocks: 1058308
Assignee: nobody → echen
blocking-b2g: --- → backlog
feature-b2g: --- → 2.2+
Whiteboard: [priority1]
Target Milestone: --- → 2.2 S2 (19dec)
Posted patch Patch, v1 (obsolete) — Splinter Review
Posted patch Patch, v2 (obsolete) — Splinter Review
Attachment #8535522 - Attachment is obsolete: true
Posted patch Patch, v3 (obsolete) — Splinter Review
Attachment #8535529 - Attachment is obsolete: true
Posted patch Patch, v4Splinter Review
Attachment #8537046 - Attachment is obsolete: true
Comment on attachment 8537105 [details] [diff] [review]
Patch, v4

Review of attachment 8537105 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Hsinyi, may I have your review? Thank you.
Attachment #8537105 - Flags: review?(htsai)
Comment on attachment 8537105 [details] [diff] [review]
Patch, v4

Review of attachment 8537105 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you ~~
Attachment #8537105 - Flags: review?(htsai) → review+
https://hg.mozilla.org/mozilla-central/rev/d16461a97b4f
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.