Closed Bug 1047203 Opened 6 years ago Closed 6 years ago

[meta][B2G][Telephony] v2.2 P1 items - define valid values and strict data types in idl interfaces

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(feature-b2g:2.2+, tracking-b2g:backlog)

RESOLVED FIXED
2.2 S3 (9jan)
feature-b2g 2.2+
tracking-b2g backlog

People

(Reporter: hsinyi, Assigned: hsinyi)

References

Details

(Whiteboard: [priority1])

User Story

Engineering Refactor: Refactoring for cleaner interfacing (v2.2 P1 items)
AC: All existing user stories from past releases should be validated after this refactor user story completes.

This is the meta bug for tracking telephony v2.2 P1 items on "defining valid values in idl".
Please contact :hsinyi for any change of bug dependency, thank you.
Take nsIMobileConnectionProvider.setPreferredNetworkType as an example.

The valid values for the parameter "type" are documented in comments, but there's no strong definitions straightly from the API itself.

In webidl, we use "enum" but how about in the internal .idl? How could we improve this?
Depends on: 1052836
Summary: [B2G] have a strong restriction on valid values in idl interfaces → [meta][B2G] have a strong restriction on valid values in idl interfaces
Depends on: 1052825
Depends on: 1052842
Depends on: 1052843
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> Take nsIMobileConnectionProvider.setPreferredNetworkType as an example.
> 
> The valid values for the parameter "type" are documented in comments, but
> there's no strong definitions straightly from the API itself.
> 
> In webidl, we use "enum" but how about in the internal .idl? How could we
> improve this?

webidl-fy nsIMobileConnectionProvider could be a solution?
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> > Take nsIMobileConnectionProvider.setPreferredNetworkType as an example.
> > 
> > The valid values for the parameter "type" are documented in comments, but
> > there's no strong definitions straightly from the API itself.
> > 
> > In webidl, we use "enum" but how about in the internal .idl? How could we
> > improve this?
> 
> webidl-fy nsIMobileConnectionProvider could be a solution?

bug 1052852 comment 0 is another option?
Depends on: 1058308
Depends on: 1058305
Depends on: 937485
Depends on: 1052852
This is the meta bug for tracking telephony v2.2 P1 items on "defining valid values in idl".
Please contact :hsinyi for any change of bug dependency, thank you.
Summary: [meta][B2G] have a strong restriction on valid values in idl interfaces → [meta][B2G][Telephony] v2.2 P1 items - define valid values in idl interfaces
User Story: (updated)
Depends on: 1047196
Summary: [meta][B2G][Telephony] v2.2 P1 items - define valid values in idl interfaces → [meta][B2G][Telephony] v2.2 P1 items - define valid values and strict data types in idl interfaces
(Commenting on User Story)
> This is the meta bug for tracking telephony v2.2 P1 items on "defining valid
> values in idl".
> Please contact :hsinyi for any change of bug dependency, thank you.
User Story: (updated)
User Story: (updated)
Depends on: 1052846
Depends on: 1052848
blocking-b2g: --- → backlog
feature-b2g: --- → 2.2+
Whiteboard: [priority1]
Depends on: 1098210
Can we find someone to own this meta bug? Thanks.
Flags: needinfo?(whuang)
Assignee: nobody → htsai
Flags: needinfo?(whuang)
Close it as all dependencies are resolved. Thank you everyone!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S3 (9jan)
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.