[meta][B2G][Telephony] v2.2 P1 items - define valid values and strict data types in idl interfaces

RESOLVED FIXED in 2.2 S3 (9jan)

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: hsinyi, Assigned: hsinyi)

Tracking

unspecified
2.2 S3 (9jan)
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.2+, tracking-b2g:backlog)

Details

(Whiteboard: [priority1])

User Story

Engineering Refactor: Refactoring for cleaner interfacing (v2.2 P1 items)
AC: All existing user stories from past releases should be validated after this refactor user story completes.

This is the meta bug for tracking telephony v2.2 P1 items on "defining valid values in idl".
Please contact :hsinyi for any change of bug dependency, thank you.
Assignee

Description

5 years ago
Take nsIMobileConnectionProvider.setPreferredNetworkType as an example.

The valid values for the parameter "type" are documented in comments, but there's no strong definitions straightly from the API itself.

In webidl, we use "enum" but how about in the internal .idl? How could we improve this?
Assignee

Updated

5 years ago
Depends on: 1052836
Assignee

Updated

5 years ago
Summary: [B2G] have a strong restriction on valid values in idl interfaces → [meta][B2G] have a strong restriction on valid values in idl interfaces
Assignee

Updated

5 years ago
Depends on: 1052825
Assignee

Updated

5 years ago
Depends on: 1052842
Assignee

Updated

5 years ago
Depends on: 1052843
Assignee

Comment 1

5 years ago
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> Take nsIMobileConnectionProvider.setPreferredNetworkType as an example.
> 
> The valid values for the parameter "type" are documented in comments, but
> there's no strong definitions straightly from the API itself.
> 
> In webidl, we use "enum" but how about in the internal .idl? How could we
> improve this?

webidl-fy nsIMobileConnectionProvider could be a solution?
Assignee

Comment 2

5 years ago
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> > Take nsIMobileConnectionProvider.setPreferredNetworkType as an example.
> > 
> > The valid values for the parameter "type" are documented in comments, but
> > there's no strong definitions straightly from the API itself.
> > 
> > In webidl, we use "enum" but how about in the internal .idl? How could we
> > improve this?
> 
> webidl-fy nsIMobileConnectionProvider could be a solution?

bug 1052852 comment 0 is another option?

Updated

5 years ago
Depends on: 1058308

Updated

5 years ago
Depends on: 1058305
Depends on: 937485
Assignee

Updated

5 years ago
Depends on: 1052852
Assignee

Comment 3

5 years ago
This is the meta bug for tracking telephony v2.2 P1 items on "defining valid values in idl".
Please contact :hsinyi for any change of bug dependency, thank you.
Summary: [meta][B2G] have a strong restriction on valid values in idl interfaces → [meta][B2G][Telephony] v2.2 P1 items - define valid values in idl interfaces
Assignee

Updated

5 years ago
User Story: (updated)
Assignee

Updated

5 years ago
Depends on: 1047196
Assignee

Updated

5 years ago
Summary: [meta][B2G][Telephony] v2.2 P1 items - define valid values in idl interfaces → [meta][B2G][Telephony] v2.2 P1 items - define valid values and strict data types in idl interfaces
(Commenting on User Story)
> This is the meta bug for tracking telephony v2.2 P1 items on "defining valid
> values in idl".
> Please contact :hsinyi for any change of bug dependency, thank you.
User Story: (updated)
User Story: (updated)
Assignee

Updated

5 years ago
Depends on: 1052846
Assignee

Updated

5 years ago
Depends on: 1052848
blocking-b2g: --- → backlog
feature-b2g: --- → 2.2+
Whiteboard: [priority1]
Assignee

Updated

5 years ago
Depends on: 1098210
Can we find someone to own this meta bug? Thanks.
Flags: needinfo?(whuang)
Assignee

Updated

5 years ago
Assignee: nobody → htsai
Flags: needinfo?(whuang)
Assignee

Comment 6

5 years ago
Close it as all dependencies are resolved. Thank you everyone!
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S3 (9jan)
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.