when lauguage changed in ftu, update hour12 value

RESOLVED FIXED in 2.1 S3 (29aug)

Status

Firefox OS
Gaia::First Time Experience
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gasolin@mozilla.com, Assigned: gasolin@mozilla.com)

Tracking

unspecified
2.1 S3 (29aug)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.1)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8472068 [details] [review]
pull request redirect to github

follow up of bug 1023735.

Update hour12 value in ftu when lauguage changed, to get correct timer format.
Attachment #8472068 - Flags: review?(francisco)
(Assignee)

Updated

4 years ago
Assignee: nobody → gasolin
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S3 (29aug)
Comment on attachment 8472068 [details] [review]
pull request redirect to github

Left some suggestions on gh, but looking pretty good to me.

Please flag me again for r? when comments are addressed.
Attachment #8472068 - Flags: review?(francisco)
(Assignee)

Comment 2

4 years ago
Comment on attachment 8472068 [details] [review]
pull request redirect to github

comments addressed, please kindly review it again
Attachment #8472068 - Flags: review?(francisco)

Updated

4 years ago
feature-b2g: --- → 2.1

Updated

4 years ago
Blocks: 903683
Comment on attachment 8472068 [details] [review]
pull request redirect to github

Thanks a lot!
Attachment #8472068 - Flags: review?(francisco) → review+
(Assignee)

Comment 4

4 years ago
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/efb6eb0a6387186c24f0fe469e61cdbe3670d37c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
The Time Format properly updates in the FTU based on the selected language.

I am unable to verify this bug until the depends on bug is verified (bug 1023735)
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
(Assignee)

Updated

4 years ago
Depends on: 1068030
You need to log in before you can comment on or make changes to this bug.