1053067 - Correct misspelling "verion" in source code

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Ed Morley [:emorley]]

Broken out from bug 577266 just so we can close that bug out.

In quite a few places "version" is spelt as "verion":
http://mxr.mozilla.org/mozilla-central/search?string=verion

Some of these places are in upstream projects (files under /security/nss/ and /media/webrtc/signaling/src/sipcc/), so will need fixing upstream separately.

Marking this a good first bug.

Comment 1

[Vikrantsingh Bisen]

I want to work on this bug.

Comment 2

[Ed Morley [:emorley]]

Go ahead :-)

Comment 3

[Vikrantsingh Bisen]

code changes done will post for review soon

Comment 4

[Vikrantsingh Bisen]

Attachment: version_spelling_correction.patch

Corrected spelling, please review my first patch.

Comment 5

[Vikrantsingh Bisen]

just to make sure, also did grep to find 'verion', and not result found except patch file

Comment 6

[Ed Morley [:emorley]]

Thank you for the patch - some of the changes touch files that need to be fixed upstream (see comment 0), so are likely best separated out.

I'd suggest:
* Patch for the mach change
* Patch for the webrtc change (with review requested from :jesup, since I'm not sure which files are from upstream and so not supposed to be modified)
* Perhaps filing a separate bug for the NSS changes, since they will likely take a lot longer (and need to be landed in a separate repository), here: https://bugzilla.mozilla.org/enter_bug.cgi?product=NSS&component=Test

Comment 7

[Vikrantsingh Bisen]

Attachment: mach_version_spelling_correction.patch

Patch for the mach change

Comment 8

[Vikrantsingh Bisen]

Attachment: webrtc_version_spelling_correction.patch

Patch for the webrtc change

Comment 9

[Vikrantsingh Bisen]

For NSS change new Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1054625 created.
Also posted patch there.

Comment 10

[Ed Morley [:emorley]]

Comment on attachment 8474076 [details] [diff] [review]
mach_version_spelling_correction.patch

These look great - thank you for breaking the NSS one out :-)

:jesup will need to say whether the sipcc changes need to go upstream or not.

Comment 11

[Vikrantsingh Bisen]

@Ed Morley, Thanks for reviewing patch. May I know what is next step ? should I checkin the mach_version_spelling_correction.patch or wait till review of webrtc_version_spelling_correction.patch and checkin both together?

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8474077 [details] [diff] [review]
webrtc_version_spelling_correction.patch

Review of attachment 8474077 [details] [diff] [review]:
-----------------------------------------------------------------

r+; and there's no upstreaming of suipcc fixes so this can just land

Comment 13

[Ed Morley [:emorley]]

The two patches here have been landed on mozilla-inbound, and will be merged to mozilla-central later today (at which point this bug will be marked resolved fixed).

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0258a0ba700
https://hg.mozilla.org/integration/mozilla-inbound/rev/746b2e3a88c5

Thank you for the patches! :-)

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e0258a0ba700
https://hg.mozilla.org/mozilla-central/rev/746b2e3a88c5