577266 - Correct misspellings in source code

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Michael Kohler [:mkohler]]

Please add new misspellings here and not in "Part 2". If the misspelling is only in "nspr" or "nss", please report it in the specific bug report (aliases "spelling-nspr" and "spelling-nss").

Comment 1

[Michael Kohler [:mkohler]]

NSPR misspellings: bug 577267
NSS misspellings: bug 577268

Comment 2

[timeless]

http://mxr.mozilla.org/mozilla-central/search?string=visibilty

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://mxr.mozilla.org/mozilla-central/search?string=satitize

Comment 4

[timeless]

http://mxr.mozilla.org/mozilla-central/source/intl/uconv/src/nsUnicodeToUTF8.cpp#56

55   // need to complete it here. If the first word in following buffer is not
56   // in valid surrogate rang, we need to convert the remaining of last buffer 

s.b. rangE

Comment 5

[timeless]

http://mxr.mozilla.org/mozilla-central/search?string=uncondtionally

Comment 6

[timeless]

http://mxr.mozilla.org/mozilla-central/search?string=Donwload

Comment 7

[timeless]

comment 6 is resolved by http://hg.mozilla.org/projects/cedar/rev/102cafb40f20

Comment 8

[(no longer active)]

(In reply to comment #7)
> comment 6 is resolved by http://hg.mozilla.org/projects/cedar/rev/102cafb40f20

http://hg.mozilla.org/mozilla-central/rev/102cafb40f20

Comment 9

[Ed Morley [:emorley]]

http://mxr.mozilla.org/mozilla-central/search?string=verion

Comment 10

[Daniel C]

http://mxr.mozilla.org/mozilla-central/search?string=compatab

Comment 11

[elic]

I'm not sure if this belongs here as it's not (just) in the source code. The About window of Thunderbird 5 has a link to "Licencing Information"

Comment 12

[Felix Fung (:felix)]

Attachment: Correcting 'verion' misspellings to 'version'

Comment 13

[Felix Fung (:felix)]

Attachment: Same as above, minus white-space changes

Comment 14

[:Margaret Leibovic]

Comment on attachment 558664 [details] [diff] [review]
Same as above, minus white-space changes

This looks good, but I think we should leave out the NSS changes because that code is managed separately (comments 0 and 1 in this bug mention that -- perhaps you could file a follow-up to bug 577268?).

If you upload a new patch without the changes in that one file, I can go ahead and land this for you!

Comment 15

[Felix Fung (:felix)]

Attachment: Remainder of spelling fixes noted in this bug

Comment 16

[Felix Fung (:felix)]

Attachment: Verion to Version, Without NSS Changes

Comment 17

[:Margaret Leibovic]

Comment on attachment 558679 [details] [diff] [review]
Remainder of spelling fixes noted in this bug

This looks good! I'm giving it an r- because I have one main concern, but I'll give it an r+ one this is fixed:

>diff --git a/mobile/app/mobile.js b/mobile/app/mobile.js
>--- a/mobile/app/mobile.js
>+++ b/mobile/app/mobile.js
>@@ -212,17 +212,17 @@ pref("extensions.getAddons.recommended.b

>-pref("extensions.compatability.locales.buildid", "0");
>+pref("extensions.compatibility.locales.buildid", "0");

I think we should leave this pref name alone because people may have come to depend on it. You could file a Fennec bug about this issue, since the people working on this code would know more about its use.

>diff --git a/mobile/chrome/content/localePicker.js b/mobile/chrome/content/localePicker.js
>--- a/mobile/chrome/content/localePicker.js
>+++ b/mobile/chrome/content/localePicker.js
>@@ -210,17 +210,17 @@ let LocaleUI = {

>-    Services.prefs.setCharPref("extensions.compatability.locales.buildid", buildID);
>+    Services.prefs.setCharPref("extensions.compatibility.locales.buildid", buildID);

This would also need to be left alone then.

>diff --git a/mobile/components/BrowserCLH.js b/mobile/components/BrowserCLH.js
>--- a/mobile/components/BrowserCLH.js
>+++ b/mobile/components/BrowserCLH.js
>@@ -121,19 +121,19 @@ function showPanelWhenReady(aWindow, aPa

>-    let localeBuildID = Services.prefs.getCharPref("extensions.compatability.locales.buildid");
>+    let localeBuildID = Services.prefs.getCharPref("extensions.compatibility.locales.buildid");

And this.

>diff --git a/mobile/components/UpdatePrompt.js b/mobile/components/UpdatePrompt.js
>--- a/mobile/components/UpdatePrompt.js
>+++ b/mobile/components/UpdatePrompt.js
>@@ -235,17 +235,17 @@ UpdatePrompt.prototype = {

>-      Services.prefs.setCharPref("extensions.compatability.locales.buildid", aUpdate.buildID);
>+      Services.prefs.setCharPref("extensions.compatibility.locales.buildid", aUpdate.buildID);

And this.

Comment 18

[:Margaret Leibovic]

Comment on attachment 558679 [details] [diff] [review]
Remainder of spelling fixes noted in this bug

Review of attachment 558679 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libvorbis/lib/vorbis_mapping0.c
@@ +63,5 @@
>    /* another 'we meant to do it this way' hack...  up to beta 4, we
>       packed 4 binary zeros here to signify one submapping in use.  We
>       now redefine that to mean four bitflags that indicate use of
>       deeper features; bit0:submappings, bit1:coupling,
> +     bit2,3:reserved. This is backward compatible with all actual uses

I realized we should also leave this change out as well, since libvorbis is external code.

::: nsprpub/pr/include/obsolete/probslet.h
@@ +88,5 @@
>  **
>  ** INPUTS:
>  **   PRInt32 num             
>  **       This argument is unused but is provided for select(unix) interface
> +**       compatibility.  All input PR_fd_set arguments are self-describing

Same thing here - we should omit this change.

Comment 19

[:Margaret Leibovic]

Comment on attachment 558679 [details] [diff] [review]
Remainder of spelling fixes noted in this bug

I'm sorry, I'm noticing even more external files, but I think I got them all!

>diff --git a/gfx/cairo/cairo/src/cairo-xlib-surface.c b/gfx/cairo/cairo/src/cairo-xlib-surface.c
>--- a/gfx/cairo/cairo/src/cairo-xlib-surface.c
>+++ b/gfx/cairo/cairo/src/cairo-xlib-surface.c

This should be left alone.

>diff --git a/ipc/chromium/src/chrome/common/visitedlink_common.cc b/ipc/chromium/src/chrome/common/visitedlink_common.cc
>--- a/ipc/chromium/src/chrome/common/visitedlink_common.cc
>+++ b/ipc/chromium/src/chrome/common/visitedlink_common.cc

And this.

Comment 20

[Felix Fung (:felix)]

Attachment: Remainder of spelling fixes noted in this bug

Addressed above changes

Comment 21

[Felix Fung (:felix)]

Attachment: Remainder of spelling fixes noted in this bug

Oops. Just noticed additional comments.

Comment 22

[:Margaret Leibovic]

(In reply to Felix Fung from comment #21)
> Created attachment 558947 [details] [diff] [review]
> Remainder of spelling fixes noted in this bug
> 
> Oops. Just noticed additional comments.

I think you missed comment 18, though :)

And I'm really hoping this is the last thing, but we should leave out the /dbm changes as well. I'm sorry to keep tacking these comments on.

Comment 23

[Felix Fung (:felix)]

Attachment: Remainder of spelling fixes noted in this bug

No more externals... hopefully.

Comment 24

[:Margaret Leibovic]

Pushed to inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/84694ee135e9
http://hg.mozilla.org/integration/mozilla-inbound/rev/750c300b9928

Comment 25

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/84694ee135e9
http://hg.mozilla.org/mozilla-central/rev/750c300b9928

Comment 26

[Ed Morley [:emorley]]

All of the instances mentioned in this bug are now fixed, apart from the ones I've broken out into clean bugs. As such lets close this out & track new issues separately (or as (no bug)).

Comment 27

[Ed Morley [:emorley]]

Few more that weren't worth filing a bug for, since they didn't involve upstream:
remote:   https://hg.mozilla.org/integration/fx-team/rev/9a3c81860040

Comment 28

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9a3c81860040