1053068 - Correct misspelling "compatab{le,ility}" in source code

Status: RESOLVED INCOMPLETE

(Core :: General, defect)

Description

[Ed Morley [:emorley]]

Broken out from bug 577266 just so we can close that bug out.

In quite a few places "compatible/compatibility" is spelt as "compatable/compatability":
http://mxr.mozilla.org/mozilla-central/search?string=compatab

Some of these places are in upstream projects (eg files under /security/nss/, /media/webrtc/trunk/tools/gyp/ and /nsprpub/), so will need fixing upstream separately.

Marking this a good first bug.

Comment 1

[Benjamin Kerensa [:bkerensa]]

(In reply to Ed Morley [:edmorley] from comment #0)
> Broken out from bug 577266 just so we can close that bug out.
> 
> In quite a few places "compatible/compatibility" is spelt as
> "compatable/compatability":
> http://mxr.mozilla.org/mozilla-central/search?string=compatab
> 
> Some of these places are in upstream projects (eg files under
> /security/nss/, /media/webrtc/trunk/tools/gyp/ and /nsprpub/), so will need
> fixing upstream separately.
> 
> Marking this a good first bug.

I will take this... Do you want these as individual patches for each instance?

Comment 2

[Ed Morley [:emorley]]

(In reply to Benjamin Kerensa [:bkerensa] from comment #1)
> I will take this... Do you want these as individual patches for each
> instance?

For each instance that is in something upstream, we'll need a separate patch. Ways to tell this are by looking at the file header, as well as glancing at the hg log to see if there are "import latest foo from upstream" type commits.

Everything else can go into one patch, which I'll rubberstamp - apart from any non comment changes (eg those in mobile/android/app/mobile.js), which would be good in another patch.

Comment 3

[Ed Morley [:emorley]]

No activity; resetting assignee.

Comment 4

[Jeffrey Tran]

(In reply to Ed Morley [:emorley] from comment #2)
> (In reply to Benjamin Kerensa [:bkerensa] from comment #1)
> > I will take this... Do you want these as individual patches for each
> > instance?
> 
> For each instance that is in something upstream, we'll need a separate
> patch. Ways to tell this are by looking at the file header, as well as
> glancing at the hg log to see if there are "import latest foo from upstream"
> type commits.
> 
> Everything else can go into one patch, which I'll rubberstamp - apart from
> any non comment changes (eg those in mobile/android/app/mobile.js), which
> would be good in another patch.

/security/nss/lib/dbm/include/hash.h was mentioned as being upstream, so I checked its header and hg log, but I don't see any comments related to upstream. Are there any more obvious/specific ways to tell a file is upstream?

Comment 5

[ST]

Hey, I want to work on this for my first bug. 

How can I tell which files are upstream so that I can create a separate patch for them? You mentioned files under /security/nss/, /media/webrtc/trunk/tools/gyp/ and /nsprpub/ are upstream and their hg logs will contain "import latest foo from upstream" type commits. Unfortunately I can't find any comments related to upstream.

Comment 6

[Ed Morley [:emorley]]

Unfortunately there isn't a clear cut answer for all cases.

I'd use your best guess (looking at hg log, file headers, checking for readmes/separate build files in the parent directory etc) to exclude the obvious upstream cases, attach a patch and then iterate from there :-)

Comment 7

[Akhil]

Hi, I want to work on this bug.

Comment 8

[Deepa]

Hi Ed,

This is what I found that contains the string "compatab",

https://dxr.mozilla.org/mozilla-central/search?q=compatab

I see one /nsprpub/ file, one /security/nss/lib and mobile/android/app/mobile.js. Should I make each of these into three separate patches, and the rest into a single patch?

Also, what is the reason behind "netwerk" directory in mozilla-central, is that also a typo?

https://dxr.mozilla.org/mozilla-central/source/netwerk

Thanks.

Comment 9

[Ed Morley [:emorley]]

I no longer work with mozilla-central so I'm not the best person to ask.

However at first glance at the DXR results, the following are all upstream so shouldn't be touched:
gfx/cairo/cairo/src/*
gfx/skia/skia/*
ipc/chromium/src/*
media/libvorbis/*
netwerk/sctp/*
nsprpub/*
obj-x86_64-pc-linux-gnu/_virtualenv/*
python/mock-1.0.0/*
security/nss/*
toolkit/crashreporter/google-breakpad/  (albeit I think we've forked this one now; ask :ted)

...and anything else is likely fair game.

Comment 10

[Ed Morley [:emorley]]

Mass-closing old bugs I filed that have not had recent activity/no longer affect me.