Closed Bug 1053251 Opened 7 years ago Closed 7 years ago

New tab page should close itself after it's hidden


(Firefox OS Graveyard :: Gaia::Search, defect)

Gonk (Firefox OS)
Not set


(Not tracked)

2.1 S3 (29aug)


(Reporter: kgrandon, Assigned: kgrandon)



(Whiteboard: [systemsfe])


(1 file)

Once the new tab page is hidden, it should close itself. Probably after a visibility change event.
Assignee: nobody → kgrandon
Target Milestone: --- → 2.1 S2 (15aug)
Attached file Github pull request
Etienne - what do you think? There two things about this that might cause it to be troublesome, but maybe they are ok for landing with this initially.

1 - If you open the new tab page, lock and unlock the screen - the new tab page is gone.

2 - The card does disappear from the stack which is awesome, but it is possible to get into a weird state if you swipe back that it will show up as the next card then disappear. I don't really think this is terrible though.
Attachment #8472653 - Flags: review?(etienne)
Comment on attachment 8472653 [details] [review]
Github pull request

It's pretty much a UX call :)

The code is really straightforward, might be a bit of a pain to test though, maybe marionette or taking hints from communications/dialer/test/unit/dialer_test.js.

Biggest issue: currently if you go into the task switcher from the new tab app everything breaks :)
This won't be an issue once the new task switcher land (launching the task switcher won't cause visibility changes only actually changing app will), but we might want to wait before landing this.
Attachment #8472653 - Flags: review?(etienne) → ui-review?(fdjabri)
Blocks: rocketbar-search-mvp
No longer blocks: 938288
Component: Gaia::System → Gaia::Search
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
Comment on attachment 8472653 [details] [review]
Github pull request

According to the new UX specs this is less of an issue now as we're using this as a task launcher type thing. Let's play with the task launcher to see if this is needed later.
Attachment #8472653 - Flags: ui-review?(fdjabri)
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.