Closed Bug 1053265 Opened 7 years ago Closed 7 years ago

[Search] Landscape support

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S3 (29aug)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
daleharvey
: review+
etienne
: review+
Details | Review
From bug 1041620 comment 22

There's no landscape view of top sites
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Summary: Add landscape view for top sites → [Search] Landscape support
Target Milestone: --- → 2.1 S3 (29aug)
Attached file Github pull request
Comment on attachment 8476430 [details] [review]
Github pull request

Hey guys, anyone have a minute for review? Thanks!
Attachment #8476430 - Flags: review?(etienne)
Attachment #8476430 - Flags: review?(dale)
Comment on attachment 8476430 [details] [review]
Github pull request

Sweet and simple :)

(Leaving Dale flagged since I don't know the grid code enough to review this part of the patch.)
Attachment #8476430 - Flags: review?(etienne) → review+
Comment on attachment 8476430 [details] [review]
Github pull request

Looks great, thanks
Attachment #8476430 - Flags: review?(dale) → review+
Updated commit with reviewers and landed: https://github.com/mozilla-b2g/gaia/commit/c13356420b355d558fa312b0546ffe8b1e88e863

Thanks guys!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.