1053271 - Remove XPCWN Xrays

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

Once nsDOMClassInfo is gone, we should be able to do this, which will significantly simplify the Xray code.

Comment 1

[Tom S. (please needinfo tschuster)]

I tried returning opaque xrays instead of XPCWN x-rays. Seems like most failures are related to SpecialPowers, at least on Linux.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ccdd181a01a

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: WIP

Yeah, I noticed the same thing. We'll need to figure out a solution for SpecialPowers.C*.

Comment 3

[Florian Bender]

Feel free to unassign if you're no longer working on this.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Note that this bug can't land until prerequisites land, and those are stalled at the moment...

Comment 5

[Tom S. (please needinfo tschuster)]

I rebased the patch and pushed to try: https://treeherder.mozilla.org/#/jobs?repoa=try&revision=73e008eaa4592cfb49c4110bae15a1dfeef875e7&selectedJob=171205078. Looks pretty good, no more SpecialPowers failure.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Peter, I think this should be able to land now...

Comment 7

[Bobby Holley (:bholley)]

There's also a ton of simplification and improvement that can happen once this goes (removing resolveNativeProperty, for one). I guess bug 1160757 tracks part of this, but we should make sure to sit down and go through the code to clean it up.

Comment 8

[Peter Van der Beken [:peterv]]

Ok, I'll get review and land this.

Comment 9

[Tom S. (please needinfo tschuster)]

The correct try link is actually https://treeherder.mozilla.org/#/jobs?repo=try&revision=73e008eaa4592cfb49c4110bae15a1dfeef875e7&selectedJob=171207521 in case you want to pull the rebased patch.

Comment 10

[Tom S. (please needinfo tschuster)]

Peter, is there anyhing that needs to be changed in the patch or should I just upload the rebased version? I kind of want to get to some of the follow up work now.

Comment 11

[Tom S. (please needinfo tschuster)]

Attachment: WIP v2

Comment 12

[Tom S. (please needinfo tschuster)]

Attachment: WIP rebased

Comment 13

[Peter Van der Beken [:peterv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=55bca9f0ee3186bda94a7efaf96f464b63879d31

Comment 14

[Peter Van der Beken [:peterv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87a53a3512da7278b85ecb3772f480b581642024

Comment 15

[Peter Van der Beken [:peterv]]

Attachment: Remove XPCWN Xrays

Comment 16

[Peter Van der Beken [:peterv]]

Attachment: Remove XrayTraits' HasPrototype

I think we could technically remove XrayWrapper<Base, Traits>::set/enumerate, but the same could be said about has/get and those are more complicated. So I'll file a separate bug about that.

Comment 17

[Peter Van der Beken [:peterv]]

Attachment: Move Sandbox proxy handlers out of XrayWrapper.h

This is just moving some code around (now that XrayWrapper doesn't use SandboxCallableProxyHandler anymore).

Comment 18

[Peter Van der Beken [:peterv]]

Attachment: Remove some unused XRayWrapper code

Just some stuff I stumbled upon while working on this.

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8983813 [details] [diff] [review]
Remove XPCWN Xrays

r=me

Comment 20

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8983835 [details] [diff] [review]
Remove XrayTraits' HasPrototype

>+      : Base(flags | WrapperFactory::IS_XRAY_WRAPPER_FLAG, true)

Maybe:

  /* aHasPrototype = */ true

?  

r=me

Comment 21

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8983836 [details] [diff] [review]
Move Sandbox proxy handlers out of XrayWrapper.h

r=me

Comment 22

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8983837 [details] [diff] [review]
Remove some unused XRayWrapper code

Nice catch.  Looks like I forgot to remove this in bug 1436276...

Comment 23

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c9e69ee274daf9d6c6eb017a92b856b88c368e
Bug 1053271 - Remove XPCWN Xrays. r=bz.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3cd7e51e9913010024d318fa6b726f335e21c48f
Bug 1053271 - Remove XrayTraits' HasPrototype. r=bz.

https://hg.mozilla.org/integration/mozilla-inbound/rev/00275042e5174f27f4a7697326dfd4a2a1c6c854
Bug 1053271 - Move Sandbox proxy handlers out of XrayWrapper.h. r=bz.

https://hg.mozilla.org/integration/mozilla-inbound/rev/509dc862a71ad7fbdcd19a257877085a6b5d21b1
Bug 1053271 - Remove some unused XRayWrapper code. r=bz.

Comment 24

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c0c9e69ee274
https://hg.mozilla.org/mozilla-central/rev/3cd7e51e9913
https://hg.mozilla.org/mozilla-central/rev/00275042e517
https://hg.mozilla.org/mozilla-central/rev/509dc862a71a