1053382 - Flame 2.0 keyboard still hangs on uppercase

Status: RESOLVED DUPLICATE of bug 1034210

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

Switched to 2.0 keyboard for a while, and we keep hanging in uppercase there. I thought that was fixed by bug 1036075. But it isn't.

Doesn't happen on master...

Rudy, any clue?

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

No, I did not see this issue when I just tested this on a v2.0 Flame.
Do you have a clear STR or were you hit by Bug 1031561?

That is a confusing feature we would keep "capslock" if you have multiple uppercase chars in front of the cursor, I removed that feature in v2.1, but not uplifted to v2.0.

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

No it happens when I type fast. Always at the start of a sentence. Doesn't wanna go back to lcase. Easy to reproduce.

Go to SMS app
Select body
Start typing fast with 2 fingers

Expected output: something like 'Kxkdsfjksajk'
Real output: 'KXKdsFJKsaJK' or 'KXKDSFJKSAJK'

See video: https://www.youtube.com/watch?v=qCLxe1_AvdI&feature=youtu.be

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

Seems I made a mistake when uplifting Bug 1034210 to v2.0.
The "keyboard" is not a global variable so we would never send both keyCode and upper keyCode to latin Engine to make the original promise-based input sequence work.

This patch corrected this wrong variable referencing.

Jan, could you please help review it?
Thanks for pointing this out.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Rudy Lu [:rudyl] from comment #3)
> Created attachment 8475662 [details] [review]
> Patch V1
> 
> Seems I made a mistake when uplifting Bug 1034210 to v2.0.
> The "keyboard" is not a global variable so we would never send both keyCode
> and upper keyCode to latin Engine to make the original promise-based input
> sequence work.
> 
> This patch corrected this wrong variable referencing.
> 
> Jan, could you please help review it?
> Thanks for pointing this out.

If you made a mistake during the uplift, you can just backout and reland the 2.0 patch without creating another 2.0 specific fix like the one here.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Understood, thanks for the advice.
Let's close this one first.