1034210 - [B2G][Keyboard] The characters on the Tamil Keyboard do not match what is seen on www.branah.com

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Tamil Keyboard.png

Description:
The keyboard that is shown on the DUT does not match the same layout as what is shown on http://www.branah.com/tamilinscript. Also when the shift key is active and the keyboard is populated with new characters, the user is unable to type any of the new characters.

Pre-req: Use 'GAIA_KEYBOARD_LAYOUTS=ko make reset-gaia' to add the Tamil keyboard to the build

Repro Steps:
1) Update a Flame to BuildID: 20140702000201
2) Open Settings App> Keyboards> Selected Keyboards
3) Select 'Add more keyboards'
4) Tap on Tamil to select> tap on English to deselect
5) Go to Homescreen> Open Messages App
6) Select Compose new message icon> Observe Keyboard layout compared to http://www.branah.com/tamilinscript
7) Tap the shift key> Try to type a newly populated characters

Actual:
The keyboard layout on the DUT does not match http://www.branah.com/tamilinscript. Also none of the characters that populate with shift active will be type-able

Expected:
Keyboard layout is correct for the Tamil language and all the characters have the ability to be typed

Environmental Variables:
Device: Flame 2.0
BuildID: 20140702000201
Gaia: 3bfe47c58c959c42f5ffe0309b5380ea514ccd69
Gecko: f40e767ea283
Version: 32.0a2 (2.0) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/12392/
See attached: Logcat, Screenshots

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on 2.1

Flame 2.1

Environmental Variables:
Device: Flame Master
Build ID: 20140702040207
Gaia: 5725321dd1aef29077b6fc5c4c49b43dccf208dc
Gecko: 7075808c3306
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

No auto-correct or word suggestion bar appears when typing


This issue does NOT occur on 1.4 Flame.

Environmental Variables:
Device: Flame 1.4
Build ID: 20140702063007
Gaia: e8599c2b346addf3bf857310502e5b542ae7d0b2
Gecko: 5ff8eb391b65
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Tamil was not an available language.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

"No auto-correct or word suggestion bar appears when typing"? This doesn't appear to be the correct actual result for 2.1

Comment 3

[Jason Smith [:jsmith]]

Delphine - Can you triage this to determine if this is a blocker for l10n?

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

Shipping locale. We should block on this until we get an answer from the localizer on what is the appropriate behavior for the keyboard

Comment 5

[Arun Prakash]

This will be ok when bug 1022339 is resolved.

Comment 6

[Arun Prakash]

http://www.branah.com/tamilinscript is made by four levels and is very complex, so we are deciding going for other keyboard layout for tamil in the above mentioned  bug 1022339.

One issue to be noted is, "when the shift key is active and the keyboard is populated with new characters, the user is unable to type any of the new characters". This is happening for hindi also. Since we are not able to type the upper case characters, i am using alt; so if you long press a character,the alternate character will be typed.

This issue needs to be addressed. I think this is happening because we are using "imEngine: 'india'"; but i am not sure.

Comment 7

[Arun Prakash]

(In reply to ktucker from comment #2)
> "No auto-correct or word suggestion bar appears when typing"? This doesn't
> appear to be the correct actual result for 2.1

This is because, there is no dictionary for tamil as of now.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Arun Prakash from comment #6)
> One issue to be noted is, "when the shift key is active and the keyboard is
> populated with new characters, the user is unable to type any of the new
> characters". This is happening for hindi also. Since we are not able to type
> the upper case characters, i am using alt; so if you long press a
> character,the alternate character will be typed.

Triage: Usability issue specific to a shipping language. 

Rudy to find the dup bug.

Comment 9

[Jason Smith [:jsmith]]

Re-adding needinfo here since it shouldn't have been cleared.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Dupe bug 1031214 to this one since this has gone through triage and have more context.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Blocking based on comment 4.

Comment 13

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Incorrect actual result for Flame 2.1 in comment 1

Actual Result for Flame 2.1: Keyboard does not match what is shown on http://www.branah.com/tamilinscript

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

[Root Cause]
In bug 1013570, we change the way keyboard.js send keycode to IM Engine, so that latin IMEngine could have both lowercase keycode and uppercase keycode, see that bug for why we need this.

However, for all non-latin IM engines, we should send the correct keycode based on the current capitalized state.

Comment 15

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

This is a band-aid fix to this issue, and also in keyboard.js without unit test protection.
However, I think it is also a minimal fix that we don't have to fix each IM engine for adopting that improper interface which need both lowercase and uppercase keycodes to be passed in.

I plan to add integration test for this, but that will need bug 1031174 to be addressed.

--
Tim, could you please help review this?
Thank you.

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Forgot to mention that this also fixed an UI issue about the [ABC] key of Tamil keyboard layout.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8454243 [details] [review]
Patch V1

Seems to be the least evil hack for now... Please update the comment to state this is a hack to be removed.

Comment 18

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8454243 [details] [review]
Patch V1

Comment updated.

Tim, could you please help review again?
Thanks.

Comment 19

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/8a7fb294444869ddaf869a58b21588752b9ce561

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/a00bc5797ccf693a13a32572252bab410f72f30e

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Reverted for being the likely cause of Gaia Python Integration Test perma-fail.
v2.0: https://github.com/mozilla-b2g/gaia/commit/f2509d29f7ee4d670d0dbc47f16e1794529aee3f

https://tbpl.mozilla.org/php/getParsedLog.php?id=43757692&tree=Mozilla-Aurora

Comment 22

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Uplifted to v2.0,
https://github.com/mozilla-b2g/gaia/commit/12afc5ca3076ea8cbcd5989b32d9d1a4f092eb8f

Comment 23

[Delphine Lebédel [:delphine - Use needinfo]]

Arun, does this appear good to you know?
thanks!

Comment 24

[Arun Prakash]

Attachment: 2014-07-26-15-40-33.png

This is working fine and verified it just now.

Comment 25

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8454243 [details] [review]
Patch V1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1013570.
[User impact] if declined: Cannot use Hindi input method. see bug 987496 comment 43, that has been approved for v1.4.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): should be low, landed to v2.0 for a while.
[String changes made]:n/a.

Comment 26

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Uplifted to Gaia v1.4,
4f92950e6d96326785a249e8acb704da3647616b

Comment 28

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Backed out and relanded to v2.0 for bug 1053382,
64b0c0ae60fdeac953a7e2a3c368d124bf848477

Comment 29

[Mike Lien[:mlien]]

verify with Flame KK v180 + v2.0 gaia/gecko, it's fine
Gaia      7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/13e04ab68621
BuildID   20140914162307
Version   32.0

Comment 30

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]

Comment 31

[Delphine Lebédel [:delphine - Use needinfo]]

Tamil isn't RTL. Correcting. thanks!