1053425 - [B2G][Loop] Users do not receive confirmation menus for "Logout"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Jordan de Geus(JordanD)]

Attachment: logcat_20140813_1317.txt

Description:
When users enter the Settings menu within the Loop app, upon selecting "Logout" or a button within "Clean shared links" menu, the user will not receive a confirmation window. 

Setup:
- Install the Loop app on a device from: https://github.com/mozilla-b2g/firefoxos-loop-client

Repro Steps:
1) Update a Flame to 20140812000205
2) Launch app> Select Settings icon
3) Tap "Logout"
4) Observe lack of confirmation menu

Actual:
Users do not receive a confirmation menu

Expected:
Users receive a confirmation menu, preventing users from accidentally mis-clicking

Environmental Variables:
Device: Flame 2.0 (319mb)
BuildID: 20140813000201
Gaia: cade2fdbb2230670788dcf2fc7b100f4a37b6458
Gecko: a7c673dae1ed
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro frequency: 3/3
See attached: Video and logcat
http://youtu.be/1nMMaBUngIo

Comment 1

[Jordan de Geus(JordanD)]

This issue occurs on Flame 2.1, Flame 2.0 (512mb)

Actual: Users do not receive a confirmation window when logging out of Loop or selecting "Clean shared links"

Flame 2.1 (319mb)

Environmental Variables:
Device: Flame Master
Build ID: 20140813040202
Gaia: 9f35fca9d818b26c06aa6b7e5c0bef25886f8f20
Gecko: 7fc96293ada8
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0 (512mb)

Environmental Variables:
Device: Flame 2.0
BuildID: 20140813000201
Gaia: cade2fdbb2230670788dcf2fc7b100f4a37b6458
Gecko: a7c673dae1ed
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

---------------------------------------------------------

Loop app is not supported on Flame 1.4 (319mb)

Flame 1.4 (319mb)

Environmental Variables:
Device: Flame 1.4
BuildID: 20140813063003
Gaia: 5bb0edb3446df787c48dbb37272827ad94cb9245
Gecko: 3d30ba3dc503
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

---------------------------------------------------------

Testers were informed not to test on Buri devices

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

The video is really blurry. Can you please upload a better quality video so i can see what is going on here?

Comment 3

[Jordan de Geus(JordanD)]

Please ignore the video URL provided in Comment 0.

New video URL: http://youtu.be/gdJqac2AYuY

Comment 4

[Jordan de Geus(JordanD)]

Loop Version: 609ec57

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

This is most likely by design but I will let mbarone weigh in on this.

Comment 6

[Maria Angeles Oteo (:oteo)]

ni, to create two different bugs to handle the log-out and the confirmation to delete shared URLs

Comment 7

[Maria Angeles Oteo (:oteo)]

After checking the Acs of the US Bug 1034615 - [User Story] As a user I would like to be able to clear my Share URL history, I remember that we did not include that confirmation intentionally, because when user tap on "Clean shared links", a submenu is shown to the users with the options:
- Clean just disable links
- Clean all. 
so it could be redundant including more confirmation screens.

What I am seeing it's still pending is when. after tapping on "Clean all" button, there are still not revoked urls and in that case the user should be warned that with this action he will not be able to revoke the URLs. Open bug 1070650 to track this issue.

Comment 8

[Maria Angeles Oteo (:oteo)]

We will track in this bug the Logout issue.
Rafa, Pau, we need a string for the Logout confirmation... 
"Are you sure you want to logout from Firefox Hello application?" That's only a proposal :)

Comment 9

[Rafael Rebolleda]

Cool :)

I'd remove "application" and add "You won't be able to make or receive calls or invitations".

Comment 10

[Pau Masiá [:Pau]]

Perfect! Agree with the changes proposed.

Comment 11

[Maria Angeles Oteo (:oteo)]

Thanks a lot, guys!
Final string: "Are you sure you want to logout from Firefox Hello? You won't be able to make or receive calls or invitations."

Assigning to Arnau, ;)

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 13

[Borja Salguero [:borjasalguero]]

Comment on attachment 8498168 [details] [review]
patch in github

Thanks! :)

Comment 14

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 8199bb873116ed6a8bf976c2309dfa6f40b28225

Comment 15

[mbarone]

Tested with Gecko-675810c.Gaia-092d2b7 and Loop v. d159db7 and works fine