105368 - make SDK vendor neutral; add packaging options

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP C SDK, defect)

Description

[Mark Smith [:mcs]]

The C SDK from mozilla.org should be vendor neutral, e.g., it should not refer
to "the iPlanet C SDK."  Other vendors may want to build their own branded C
SDK.  To accomplish this, I will add two new gmake options:

VENDOR_NAME=string   SDK vendor name (default mozilla.org)
VENDOR_VERSION=#     vendor specific version number * 100 (default 500)

It would also be nice to have more flexibility with respect to packaging.  I
propose to implement these gmake options:

   PKG_PRIVATE_HDRS=0   do not ship private headers
   PKG_PRIVATE_LIBS=0   do not ship private libraries
   PKG_DEP_LIBS=0       do not ship dependent libraries

Comment 1

[Mark Smith [:mcs]]

Attachment: changes to existing files

Comment 2

[Mark Smith [:mcs]]

Attachment: new file: replace.pl script

Comment 3

[Mark Smith [:mcs]]

Attachment: new file: ldap-standard-tmpl.h

Comment 4

[Mark Smith [:mcs]]

All of the changes are included in the bug attachments except for one:
mozilla/directory/c-sdk/ldap/include/ldap-standard.h will be removed (because it
is now generated from ldap-standard-tmpl.h using the new replace.pl script).

I tested these changes on Solaris 8 and Windows 2000.

Comment 5

[Mark Smith [:mcs]]

Attachment: diffs between the old ldap-standard.h and ldap-standard-tmpl.h

Comment 6

[Rich Megginson]

Added myself to CC list.

Comment 7

[dlb]

BTW, the SDK also contains references to Airius.com

I'm told we are no longer able to legally use this (apparently it now belongs to
a former iPlanet employee -- see http://airius.com).

Comment 8

[Mark Smith [:mcs]]

Attachment: Remove references to Airius

Comment 9

[Mark Smith [:mcs]]

The last attachment shows the changes needed to change all references to
Airius.com to example.com.  Note that there are some remaining references to
Airius in one source file:

  mozilla/directory/c-sdk/ldap/clients/tools/examples-from-ldif-spec.ldif

That file contains the LDIF examples from RFC 2849, and since we can't change
the RFC we won't change that file (it is not typically shipped as part of a
vendor's binary C SDK distribution anyway).

Comment 10

[Mark Smith [:mcs]]

Attachment: updated changes to existing files

Comment 11

[Mark Smith [:mcs]]

The final changes (see http://bugzilla.mozilla.org/attachment.cgi?id=54541)
differ from the original proposal in these ways:

a) NSS version changed from 3.3 to 3.3.1

b) Static LDAP libraries are included in the package even when
PKG_PRIVATE_LIBS=0 (but the ituil library is not included).

Fix committed:

/mozilla/directory/Makefile
  new revision: 1.1.16.1.2.1.2.22; previous revision: 1.1.16.1.2.1.2.21
/mozilla/directory/c-sdk/build.mk
  new revision: 1.1.2.35; previous revision: 1.1.2.34
/mozilla/directory/c-sdk/package.mk
  new revision: 1.1.2.13; previous revision: 1.1.2.12
/mozilla/directory/c-sdk/ldap/build/replace.pl (new file)
  new revision: 1.1.2.1; previous revision: 1.1
/mozilla/directory/c-sdk/ldap/clients/tools/Makefile.client
  new revision: 1.1.2.35; previous revision: 1.1.2.34
/mozilla/directory/c-sdk/ldap/docs/relnotes_41.htm
  new revision: 1.1.2.2; previous revision: 1.1.2.1
/mozilla/directory/c-sdk/ldap/examples/README
  new revision: 1.1.2.1.2.2; previous revision: 1.1.2.1.2.1
/mozilla/directory/c-sdk/ldap/examples/examples.h
  new revision: 1.1.2.1.2.2; previous revision: 1.1.2.1.2.1
/mozilla/directory/c-sdk/ldap/examples/modattrs.c
  new revision: 1.1.2.1.2.2; previous revision: 1.1.2.1.2.1
/mozilla/directory/c-sdk/ldap/examples/modrdn.c
  new revision: 1.1.2.1.2.2; previous revision: 1.1.2.1.2.1
/mozilla/directory/c-sdk/ldap/examples/srvrsort.c
  new revision: 1.1.2.1.2.2; previous revision: 1.1.2.1.2.1
/mozilla/directory/c-sdk/ldap/examples/ssearch.c
  new revision: 1.1.2.1.2.2; previous revision: 1.1.2.1.2.1
/mozilla/directory/c-sdk/ldap/examples/ssnoauth.c
  new revision: 1.1.2.1.2.3; previous revision: 1.1.2.1.2.2
/mozilla/directory/c-sdk/ldap/examples/windows/winldap/winldap.cpp
  new revision: 1.1.2.1.2.1; previous revision: 1.1.2.1
/mozilla/directory/c-sdk/ldap/include/Makefile.client
  new revision: 1.2.16.1.56.9; previous revision: 1.2.16.1.56.8
/mozilla/directory/c-sdk/ldap/include/ldap-extension.h
  new revision: 1.1.2.4; previous revision: 1.1.2.3
/mozilla/directory/c-sdk/ldap/include/ldap-standard-tmpl.h (new file)
  new revision: 1.1.2.1; previous revision: 1.1
/mozilla/directory/c-sdk/ldap/include/ldap-standard.h (deleted file)
  new revision: delete; previous revision: 1.1.2.1
/mozilla/directory/c-sdk/ldap/libraries/libiutil/Makefile.client
  new revision: 1.1.2.9; previous revision: 1.1.2.8
/mozilla/directory/c-sdk/ldap/libraries/libldap/Makefile.client
  new revision: 1.2.16.1.20.1.2.17; previous revision: 1.2.16.1.20.1.2.16
/mozilla/directory/c-sdk/ldap/libraries/libldap/nsprthreadtest.c
  new revision: 1.1.16.1.20.2.2.2; previous revision: 1.1.16.1.20.2.2.1
/mozilla/directory/c-sdk/ldap/libraries/libldap/pthreadtest.c
  new revision: 1.2.2.2.20.2.2.2; previous revision: 1.2.2.2.20.2.2.1
/mozilla/directory/c-sdk/ldap/libraries/libprldap/Makefile.client
  new revision: 1.1.2.1.2.9; previous revision: 1.1.2.1.2.8
/mozilla/directory/c-sdk/ldap/libraries/libssldap/Makefile.client
  new revision: 1.1.2.10; previous revision: 1.1.2.9
    Use NSS 3.3.1 (previously was using NSS 3.3).
    Vendor independence:
        add VENDOR_NAME and VENDOR_VERSION gmake variables.
    New packaging options:
        PKG_PRIVATE_HDRS=0   do not ship private headers
        PKG_PRIVATE_LIBS=0   do not ship private libraries
        PKG_DEP_LIBS=0       do not ship dependent libraries
    Remove references to Airius (not safe to use in examples).

Comment 12

[Frankie]

Spam for bug 129472