1053937 - Visiting localhost prevents later tiles from being shown

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

I tested visiting localhost:8000 on a new profile and directory tiles stopped showing up.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Also fixes some subdomain of localhost that could end up triggering dns.

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8473152 [details] [diff] [review]
v1

Review of attachment 8473152 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/DirectoryLinksProvider.jsm
@@ +188,5 @@
> +    try {
> +      return Services.eTLD.getBaseDomain(linkURI);
> +    }
> +    catch(ex) {
> +      return linkURI.asciiHost;

To avoid a JS engine strict warning, if those are even still a thing, please make the catch empty and return asciiHost after the catch.

Comment 3

[Ed Lee :Mardak]

Attachment: for checkin

(In reply to Drew Willcoxon :adw from comment #2)
> > +    catch(ex) {
> > +      return linkURI.asciiHost;
> To avoid a JS engine strict warning, if those are even still a thing, please
> make the catch empty and return asciiHost after the catch.
Done.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5768f6b78c57

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Uplift has been managed in bug 1057602

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cd0f797c10ca