1053997 - reduce crash potential in our e10s test addons

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Tomislav Jovanovic :zombie]

in bug 1050391, we might be inviting too much trouble for ourself, running e10s tests in an unsupported way: starting without .autostart enabled, opening an e10s window before each test, and closing it after, which probably stress-tests the still unreliable e10s code in platform (not SDK code).

a better procedure in e10s test addons might be:
1) close the non-e10s window
2) open an e10s window
3) run the tests
4) restore starting position on unload

bonus step (belt and suspenders):
5) verify/restore starting position in Dave's changed test-runner between addon uninstall/install..

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1586

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8473318 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1586

Up to you if you want to keep all the tests running to see how they fare on tbpl

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/3360de7267ce2a7f859787287873ecb2d824cc93
bug 1053997 - reduce e10s crash potential

https://github.com/mozilla/addon-sdk/commit/e5a54f89076a1bb08f1c10a7d96f4bfff5d59ca6
Merge pull request #1586 from zombie/1053997-e10s-crashes

bug 1053997 - reduce e10s crash potential, r=@Mossop

Comment 4

[Tomislav Jovanovic :zombie]

(In reply to Dave Townsend [:mossop] from comment #2)
> Up to you if you want to keep all the tests running to see how they fare on tbpl

i know how they would fare: they would fail (spectacularly), because of rejected promises in tabbrowser.xml. 

i figure getting to the green tree is more important ATM.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Something landed in here, can we close this bug or is there more to do here?

Comment 6

[Tomislav Jovanovic :zombie]

yup