1054035 - Block about urls in guest mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We talked in bug 1046941 about disabling about pages in guest mode as well, to prevent using about:config to revert prefs. That feels a bit strict to me, but I'd rather be too strict than too lenient. This may mean we also should disable the About Firefox setting in prefs.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

For our future selves. The thought here with tracking 35+ is that it should track whatever release the lockscreen widget is shipping on (which may be 35).

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch v1

I decided to make this just block about:config. Mostly because I can foresee someone wanting about:x and filing the bug to get it re-enabled.

It felt weird that we ask the parental controls "Is this blocked" then ignore what it says if the url isn't in a blocklist in javascript, so I moved that blocklist into Java. This still feels a bit weird because we have a blocklist in java that applies to all RestrictedProfiles. I'm not sure where the parent would say "I want files urls, but not playboy ones" here. Maybe these schemes/urls need to go in GuestProfile.java and this is GuestProfile specific?

But this seems better than before, so the code keeps improving :)

Oh, I also made geckoActionToRestriction return a Restriction object because that makes sense to me.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8495590 [details] [diff] [review]
Patch v1

>diff --git a/mobile/android/base/RestrictedProfiles.java b/mobile/android/base/RestrictedProfiles.java

>+import java.util.HashSet;
> import java.util.HashSet;

You don't need two

>+    /* This is a list of things we can restrict you from doing. Some of these are reflected in Android UserManager constants.
>+     * Others are specific to us.
>+     * These constants should be in sync with the ones from toolkit/components/parentalcontrols/nsIParentalControlServices.java
>+     */

Typo: nsIParentalControlServices.idl

>+    private static boolean canLoadUrl(final String url) {

>+            if (!GeckoAppShell.getGeckoInterface().getProfile().inGuestMode() &&

This is the fourth time we use this line of code. Is it possible to cache it in a static, since it won't change during the lifetime of the class?

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/be045ef85f3f

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/be045ef85f3f

Comment 6

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in
Build: Firefox for Android 35.0a1 (2014-10-01)
Device: Nexus 4 (Android 4.4.4)

about:config page is disabled in guest mode.