Closed
Bug 1054122
Opened 10 years ago
Closed 10 years ago
There are still some redundant BT code in settings app
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eragonj, Assigned: iliu)
References
Details
Attachments
(1 file)
It seems that there is a timing that Ian just removed the whole BT app from settings while chens just updated some code in settings/BT to make part of codes back.
And the most interesting stuff is Github still let him merge code without conflict. So right now in Settings app, there are some duplicated codes there are need to be ported into BT app.
Please check the updated code here :
https://github.com/mozilla-b2g/gaia/commit/eae74908a7ab8493691b7fc6ec91d969821d9798
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → iliu
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
Since Arthur has reviewed the two patch before. It's better to request Arthur to check the change again. Thanks.
Attachment #8473451 -
Flags: review?(arthur.chen)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8473451 [details] [review]
pull request 22907
r=me, thanks!
Attachment #8473451 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks for reviewing effort.
Gaia/master: 3c7d232fa75ce9d8fda13982a38ee561c4944a9d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•