1061437 - [Settings] Revert bug 1032071 and bug 1054122

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/23563

In bug 1032071 we embedded the BT app in settings app by using an iframe with mozapp and mozbrowser attributes. However, currently gecko does not support OOP apps embed apps yet (see bug 1059662) and which leads to crash of settings app (bug 1053107), so we decide to back out related patches.

EJ and Ian, would you mind take a look at the patch? Thanks.

Comment 1

[[e-mail], [e-mail]]

Comment on attachment 8482512 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/23563

The revert patch is okay for me on build version 20140829040202. Looks like latest build is not working fine with mozSettings. We see some problem in all of settings app(not only bluetooth app). It might be relative with Bug 900551.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing!

master: 5558ad0b068b5ddf45d7a532e133ab88a47f0beb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Note that due to recent policy changes, all B2G uplifts needs approval now regardless of blocking status. Please request Gaia v2.1 approval on this patch when you get a chance. Sorry for the inconvenience.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Uplifted with IRC a=bajaj.
v2.1: https://github.com/mozilla-b2g/gaia/commit/fbb297c39aab5f17b179533d2a9a6c5166b2c197