1054144 - Add support for 'tfdt' in MP4 parser

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

The stagefright MP4 parser ignores the MSE specific 'tfdt' box which contains baseMediaDecodeTime. This box gives a way to specify fragment start time.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Support 'tfdt' in MP4 parser

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8473486 [details] [diff] [review]
Support 'tfdt' in MP4 parser

Review of attachment 8473486 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +113,5 @@
>      status_t parseSampleAuxiliaryInformationOffsets(off64_t offset, off64_t size);
>  
> +    struct TrackFragmentData {
> +      uint32_t mFlags;
> +      uint64_t mBaseMediaDecodeTime;

4 space indent in this file.

@@ +115,5 @@
> +    struct TrackFragmentData {
> +      uint32_t mFlags;
> +      uint64_t mBaseMediaDecodeTime;
> +    };
> +    TrackFragmentData mTrackFragmentData;

Initialise in ctor.

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Support 'tfdt' in MP4 parser

Made it behave better when tfdt isn't present

Comment 4

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8474283 [details] [diff] [review]
Support 'tfdt' in MP4 parser

Review of attachment 8474283 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +3501,5 @@
>  
>              mCurrentMoofOffset = nextMoof;
>              mCurrentSamples.clear();
>              mCurrentSampleIndex = 0;
> +            mTrackFragmentData.mPresent = false;;

While I can appreciate wanting to be extra sure that this statement is punctuated, I think the one semicolon will suffice.

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03a28ad6fce5

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/03a28ad6fce5