Add support for 'tfdt' in MP4 parser

RESOLVED FIXED in mozilla34

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ajones, Assigned: ajones)

Tracking

(Blocks: 1 bug)

Trunk
mozilla34
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The stagefright MP4 parser ignores the MSE specific 'tfdt' box which contains baseMediaDecodeTime. This box gives a way to specify fragment start time.
Assignee: nobody → ajones
Status: NEW → ASSIGNED
Comment on attachment 8473486 [details] [diff] [review]
Support 'tfdt' in MP4 parser

Review of attachment 8473486 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +113,5 @@
>      status_t parseSampleAuxiliaryInformationOffsets(off64_t offset, off64_t size);
>  
> +    struct TrackFragmentData {
> +      uint32_t mFlags;
> +      uint64_t mBaseMediaDecodeTime;

4 space indent in this file.

@@ +115,5 @@
> +    struct TrackFragmentData {
> +      uint32_t mFlags;
> +      uint64_t mBaseMediaDecodeTime;
> +    };
> +    TrackFragmentData mTrackFragmentData;

Initialise in ctor.
Attachment #8473486 - Flags: review?(edwin) → review+
Made it behave better when tfdt isn't present
Attachment #8474283 - Flags: review?(edwin)
Attachment #8473486 - Attachment is obsolete: true
Comment on attachment 8474283 [details] [diff] [review]
Support 'tfdt' in MP4 parser

Review of attachment 8474283 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +3501,5 @@
>  
>              mCurrentMoofOffset = nextMoof;
>              mCurrentSamples.clear();
>              mCurrentSampleIndex = 0;
> +            mTrackFragmentData.mPresent = false;;

While I can appreciate wanting to be extra sure that this statement is punctuated, I think the one semicolon will suffice.
Attachment #8474283 - Flags: review?(edwin) → review+
https://hg.mozilla.org/mozilla-central/rev/03a28ad6fce5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.