'tfdt' being ignored during seek in MP4 file

RESOLVED FIXED in mozilla34

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kentuckyfriedtakahe, Assigned: kentuckyfriedtakahe)

Tracking

Trunk
mozilla34
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Seeking in a fragmented MP4 file gets the wrong time offset because we're not applying the BaseMediaDecodeTime to our offset.
Created attachment 8477204 [details] [diff] [review]
Use tfdt box data when seeking in MP4
Attachment #8477204 - Flags: review?(edwin)
Assignee: nobody → ajones
Status: NEW → ASSIGNED
Created attachment 8478051 [details] [diff] [review]
Fix tfdt handling for files with multiple tracks
Attachment #8478051 - Flags: review?(edwin)
Blocks: 1057911
Comment on attachment 8478051 [details] [diff] [review]
Fix tfdt handling for files with multiple tracks

Review of attachment 8478051 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, though the whitespace changes make it difficult to tell what changed functionally -- would much prefer that they be separate next time.
Attachment #8478051 - Flags: review?(edwin) → review+
https://hg.mozilla.org/mozilla-central/rev/1c3d4db4d7bc
https://hg.mozilla.org/mozilla-central/rev/aabb54f965b7
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.