1056485 - 'tfdt' being ignored during seek in MP4 file

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Seeking in a fragmented MP4 file gets the wrong time offset because we're not applying the BaseMediaDecodeTime to our offset.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Use tfdt box data when seeking in MP4

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix tfdt handling for files with multiple tracks

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8478051 [details] [diff] [review]
Fix tfdt handling for files with multiple tracks

Review of attachment 8478051 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, though the whitespace changes make it difficult to tell what changed functionally -- would much prefer that they be separate next time.

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c3d4db4d7bc
https://hg.mozilla.org/integration/mozilla-inbound/rev/aabb54f965b7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c3d4db4d7bc
https://hg.mozilla.org/mozilla-central/rev/aabb54f965b7