Closed Bug 1054178 Opened 10 years ago Closed 10 years ago

[Gaia][calendar] support 24 hour time format

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86
macOS
defect
Not set
normal

Tracking

(feature-b2g:2.1)

VERIFIED FIXED
2.1 S3 (29aug)
feature-b2g 2.1

People

(Reporter: evanxd, Assigned: evanxd)

References

Details

(Whiteboard: [p=10])

Attachments

(1 file)

There will be a setting toggle to let user choose between 12/24 hour time format in v2.1. User story and settings spec: Bug 903683

For each app, the tasks to do after toggle is added would be:
1.Read/listen to the time format toggle value/change event.

2.Input the corresponding time format to existing mozL10n.DateTimeFormat() function. Currently the input time format should be a fixed 12 hour 
shortTimeFormat = %I:%M %p , line 201 of http://goo.gl/DR4CNe. There will be a 24 hour time format added.

3.Show the return of the function as it's doing now.
Target Milestone: --- → 2.1 S3 (29aug)
QA Contact: edchen
feature-b2g: --- → 2.1
Whiteboard: [p=5]
Hi Harly,

Could you help to review the patch?

Thanks.
Attachment #8475753 - Flags: ui-review?(hhsu)
Comment on attachment 8475753 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23063

Nicely done, thank you Evan!
Attachment #8475753 - Flags: ui-review?(hhsu) → ui-review+
Thanks for the review, Harly.

The ui-review+ patch: https://github.com/evanxd/gaia/commit/ece910278001bccf2be9a6c27acfbcbf17e8d274
Comment on attachment 8475753 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23063

Hi Miller,

Could you help to review the patch?
And I will add/fix the tests later.

Thanks.
Attachment #8475753 - Flags: review?(mmedeiros)
Confirmed with EM/EPM, and this can be landed before FL.
Hi Miller,

I already updated the patch for the comments.
Could you help to review it?

Thanks.
Flags: needinfo?(mmedeiros)
Comment on attachment 8475753 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23063

good work
Attachment #8475753 - Flags: review?(mmedeiros) → review+
Flags: needinfo?(mmedeiros)
Waiting for try server result.
The failures of the CI result[1] is not related with this patch. The failures already happened in the current master branch[2].

[1] https://tbpl.mozilla.org/?rev=51d6b6ecdabf434a7632269a0a0db6568347d30a&tree=Gaia-Try
[2] https://tbpl.mozilla.org/?rev=2630942878d87fdf06983b9883b0fc0af23f4180&tree=Gaia-Try
Hi Dylan,

Tree is closed now.
We could land this patch once tree reopens, or we should land it now?

If we would like to land it now, could you help to land it. I have no permission to do that.

Thanks.
Flags: needinfo?(doliver)
Tree is reopened now. :D
Flags: needinfo?(doliver)
The failures of the CI result[1] is not related with this patch. The failures already happened in the current master branch[2]. And we could fix them in other patch. So let's land the code. :D

[1] https://tbpl.mozilla.org/?rev=590ced5e5875&tree=Gaia-Try
[2] https://tbpl.mozilla.org/?rev=b50946fac9245b04877d9065c1135cdd84f5c608&tree=Gaia-Try
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [p=5] → [p=10]
[Environment]
Gaia      fbb297c39aab5f17b179533d2a9a6c5166b2c197
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/fb5e796da813
BuildID   20140902160204
Version   34.0a2
ro.build.version.incremental=eng.cltbld.20140820.195518
ro.build.date=Wed Aug 20 19:55:28 EDT 2014


[Result]
PASS
Status: RESOLVED → VERIFIED
QA Whiteboard: [COM=Gaia::Calendar]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: