Closed
Bug 1054229
Opened 11 years ago
Closed 11 years ago
Follow-up of bug 1024298: Remove unused numberLayout from layout loader
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
2.1 S4 (12sep)
People
(Reporter: mnjul, Assigned: mnjul)
References
Details
Attachments
(1 file)
This bug will do the issue 2 in the tracking bug 1054145:
Removal of numberLayout from layout loader: https://github.com/mnjul/gaia/blob/8763293e39d5121000c3b9b76b1583865442ae39/apps/keyboard/js/keyboard/layout_loader.js#L80-L103 since it's no longer used.
|
Assignee | |
Comment 1•11 years ago
|
||
Let's have the patch tested.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8473627 [details] [review]
Patch (PR @ GitHub)
Hi Rudy,
Simple patch for you to review. Thanks!
Attachment #8473627 -
Flags: review?(rlu)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8473627 [details] [review]
Patch (PR @ GitHub)
Looks good to me.
Thanks.
Attachment #8473627 -
Flags: review?(rlu) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Quick note: I'd like to defer this to after FL of 2.1 to avoid regression/blocker.
Target Milestone: --- → 2.1 S4 (12sep)
|
|
Assignee | |
Comment 5•11 years ago
|
||
bug 1024298 got reverted and wontfix'ed, so these bugs are invalid now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•