Closed Bug 1054371 Opened 6 years ago Closed 6 years ago

Update tablet toolbar 'back' button to match new UI

Categories

(Firefox for Android :: Theme and Visual Design, defect)

x86
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 34

People

(Reporter: antlam, Assigned: lucasr)

References

Details

Attachments

(9 files)

The back button needs the same stroke as the input bar to match. Mockups coming!
Attaching mockup.

The color for the stroke is #B6B6B6, I've used the same thickness for consistencies sake for now. But for the "forward" button it looks really thick. Let's see how it looks in practice? (in the mock here it's a bit thinner [1px vs 2px])
^oh, the back icon should be inactive (a lighter grey) in this mock since the user is on the first page and can't go back. Shouldn't be an issue but thought I'd call it out.
Attachment #8473996 - Flags: review?(michael.l.comella)
Attachment #8473997 - Flags: review?(michael.l.comella)
Attachment #8473998 - Flags: review?(michael.l.comella)
Attachment #8473999 - Flags: review?(michael.l.comella)
Attached image Screenshot
I think the line on the forward button is a bit too strong. But I think it's thin enough though. Maybe this is a matter of using a different color?
Attachment #8474006 - Flags: feedback?(alam)
Picked the stroke color from the images. Looks alright to me.
Attachment #8474007 - Flags: feedback?(alam)
Comment on attachment 8474007 [details]
Screenshot (Private mode)

I agree, this is good for now -  there's been the outstanding issues for the chrome visuals itself in bug 864958 that we should keep in mind in the future.
Attachment #8474007 - Flags: feedback?(alam) → feedback+
Comment on attachment 8474006 [details]
Screenshot

There also seems to be a gap on top and below the line (so it doesn't actually connect to the top and bottom). 

More specifically for color, let's try #BFBFBF. I don't have another color that lies in that range and I don't want to randomly add a new color to our guides to keep things consistent. So, we could try that for now (since this button isn't as dominant) :)
Attachment #8474006 - Flags: feedback?(alam) → feedback-
^ sorry for the sequential posts :P but is it me or is this stroke also not on the far right-est of the button? I think I see some color coming in on the right side of it..
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Attachment #8473996 - Flags: review?(michael.l.comella) → review+
Attachment #8473997 - Flags: review?(michael.l.comella) → review+
Attachment #8473998 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8473999 [details] [diff] [review]
Part 4: Make all members of BackButton/ForwardButton final (r=mcomella)

Review of attachment 8473999 [details] [diff] [review]:
-----------------------------------------------------------------

:D
Attachment #8473999 - Flags: review?(michael.l.comella) → review+
Attached image Screenshot
Removed the spacing on top/bottom of forward button and used BFBFBF. Looks good to me. Thoughts?
Attachment #8476675 - Flags: feedback?(alam)
Comment on attachment 8476675 [details]
Screenshot

PLUS! looking good
Attachment #8476675 - Flags: feedback?(alam) → feedback+
You need to log in before you can comment on or make changes to this bug.