Closed Bug 1054466 Opened 7 years ago Closed 7 years ago

Update overflow menu to meet new interaction and UX specs

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S3 (29aug)

People

(Reporter: pdol, Assigned: daleharvey)

References

Details

(Whiteboard: systemsfe)

Attachments

(1 file)

Page 18:
https://mozilla.app.box.com/s/lbw2wzw3p4jvxs24k4sg/1/2099951272/19877711201/1

Note that the visual design will remain the same as the old one.
"Open link in new tab" should be "Open in new window".
"Add to home screen" is not present, currently.
Blocks: 941214
Blocks: browser-chrome-mvp
No longer blocks: 941214
Depends on: 1054455
As mentioned in the meeting, I originally implemented the overflow menu to trigger a context menu that way the styling would be consistent across applications, not sure how it was revived without it, but seems an easy way to keep this consistent
I think the terminology here is wrong. I believe this bug is about the context menu, which is the one we long-press to open, correct?
Summary: Update overflow menu to meet new interaction and UX specs → Update context menu to meet new interaction and UX specs
Summary: Update context menu to meet new interaction and UX specs → Update overflow menu to meet new interaction and UX specs
No longer depends on: 1054455
Attachment #8481520 - Flags: review?(kgrandon)
I didnt want to remove 'addBookmark', just in case it was used elsewhere, but it should also be safe to remove as far as I can tell
Looks like there's a unit test failure here - can you address it?
Flags: needinfo?(dale)
Yup fixed now, new async code in there so have it wait until the dialog is displayed
Flags: needinfo?(dale)
Comment on attachment 8481520 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23503

Seems fine to me, thanks.
Attachment #8481520 - Flags: review?(kgrandon) → review+
https://github.com/mozilla-b2g/gaia/commit/838213d40dcba2e37b9e397c162aa5e44e9e64e7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Apologies, when I pushed the try was green but I didnt check that Gu had actually completed

Its looking green now, I removed the unit test as it was invalid and its usecase is well covered by an integration test now, had a green run except some integration test perma fails, rebased and should hopefully be green

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=74f69e3aafa7
Flags: needinfo?(dale)
Try run looks good. The only failing test was recently disabled on TBPL, so we should be fine here.

Re-landing: https://github.com/mozilla-b2g/gaia/commit/5bbb8889656c45aeb101c13ea0f23cb685ee7ed1
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.