1054559 - Page title on Create New Profile page does not show up when “connect my MDN account” banner is displayed

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Sign-in, defect)

Description

[Holly Habstritt Gaal [:Habber]]

Page title on Create New Profile page does not show up when “connect my MDN account” banner is displayed. 

URL: https://developer-dev.allizom.org/en-US/users/account/signup

The page title on Create New Profile page does not display when “connect my MDN account” banner is displayed. A notification banner should not take the place of a page title. Page titles are a persistent element.

Page without banner (title shown): http://cl.ly/image/0H0k002X2v1o
Page with banner (No title shown): http://cl.ly/image/1I1g0O0I0i36


How did I get here?
After I authorized application (http://cl.ly/image/112H2l443936), I was brought back to MDN (http://cl.ly/image/1I1g0O0I0i36) 

I saw the banner and knew I needed to take action to connect my MDN acct. 

However, I was left guessing what the rest of the fields were for. Once I saw the “Create a new profile” submit button at the bottom of the page, I realized that this was the page for creating a new profile. This should be immediately apparent. Adding a simple title to this page that says “Create your profile to continue” will make this clear. (this bug addresses missing title. I will create a separate bug for the page title copy itself).

Comment 1

[Stephanie Hobson [:shobson]]

The title of this page is listed on Bug #1054560 comment 22 (https://bugzilla.mozilla.org/show_bug.cgi?id=866533#c22)

Comment 2

[Stephanie Hobson [:shobson]]

Not that. This:

The title of this page is listed on Bug #866533 comment 22 (https://bugzilla.mozilla.org/show_bug.cgi?id=866533#c22)

/me wishes we could delete comments.

Comment 3

[Holly Habstritt Gaal [:Habber]]

(In reply to Stephanie Hobson [:shobson] from comment #2)
> Not that. This:
> 
> The title of this page is listed on Bug #866533 comment 22
> (https://bugzilla.mozilla.org/show_bug.cgi?id=866533#c22)
> 
> /me wishes we could delete comments.

Thanks, Stephanie!

Comment 4

[Māris Fogels [:mars] (please needinfo)]

Shutting of bug pager alarms

Comment 5

[Stephanie Hobson [:shobson]]

John is going to handle this in combination with bug #866533

Comment 6

[John Karahalis [:openjck]]

Stephanie is correct. Both this bug and bug 866533 will be addressed by the following pull request.

https://github.com/mozilla/kuma/pull/2691

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/1d2505c571278ab89414cc3e110fef031d0704b4
Fix bug 866533, 1054559: Update registration page

Update the registration page copy (bug 866533). In updating the copy, we
ensure that the copy is visible even when a user signs in with GitHub
(bug 1054559).

https://github.com/mozilla/kuma/commit/9aa0997274661aa8523330a8a4a0938d21d60944
Merge pull request #2698 from groovecoder/registration-copy-866533

Fix bug 866533, 1054559: Update registration page