1054773 - [Web Components] Progress element causes crash [@ nsIDocument::CreateHTMLElement(nsIAtom*) ]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kevin Grandon :kgrandon]

Example test case: http://gaia-elements.github.io/progress/element/examples/index.html

Crash report: https://crash-stats.mozilla.com/report/index/12fd1e02-01e1-4576-b398-832e22140817

Comment 1

[Kevin Grandon :kgrandon]

William - could you take a look when you get a chance? Could it be a duplicate? Thanks!

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I thought I had fixed this one.
http://hg.mozilla.org/mozilla-central/annotate/94ba78a42305/layout/forms/nsProgressFrame.cpp#l62
needs to use GetComposedDoc(), not GetDocument()

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: random_getcomposeddoc_fixes.diff

These should be rather obvious fixes.

I'm looking at still some non-obvious ones.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Do you have a recent Try link handy by chance? :)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

No. This really shouldn't need one.
This is just fixing a class of crasher bugs. (null-pointer crashes)

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96ba07052d59

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/96ba07052d59