[Web Components] Progress element causes crash [@ nsIDocument::CreateHTMLElement(nsIAtom*) ]

RESOLVED FIXED in mozilla34

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: smaug)

Tracking

unspecified
mozilla34
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Example test case: http://gaia-elements.github.io/progress/element/examples/index.html

Crash report: https://crash-stats.mozilla.com/report/index/12fd1e02-01e1-4576-b398-832e22140817
(Reporter)

Comment 1

3 years ago
William - could you take a look when you get a chance? Could it be a duplicate? Thanks!
Flags: needinfo?(wchen)
I thought I had fixed this one.
http://hg.mozilla.org/mozilla-central/annotate/94ba78a42305/layout/forms/nsProgressFrame.cpp#l62
needs to use GetComposedDoc(), not GetDocument()
Assignee: nobody → bugs
Created attachment 8475307 [details] [diff] [review]
random_getcomposeddoc_fixes.diff

These should be rather obvious fixes.

I'm looking at still some non-obvious ones.
Attachment #8475307 - Flags: review?(wchen)
Flags: needinfo?(wchen)

Updated

3 years ago
Attachment #8475307 - Flags: review?(wchen) → review+
Keywords: checkin-needed
Do you have a recent Try link handy by chance? :)
Keywords: checkin-needed
No. This really shouldn't need one.
This is just fixing a class of crasher bugs. (null-pointer crashes)
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/96ba07052d59
Keywords: checkin-needed

Comment 7

3 years ago
https://hg.mozilla.org/mozilla-central/rev/96ba07052d59
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.