Closed
Bug 1054766
(gaia-progress)
Opened 11 years ago
Closed 11 years ago
Create a gaia-progress web component
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S3 (29aug)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
A gaia-progress component can be used in the system app, and potentially other places that shows a progress element. (Calendar/email may also be good candidates).
|
Assignee | |
Comment 1•11 years ago
|
||
This is in progress *hah*, but I am currently running into some platform crashes. Bug coming soon.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8474262 [details] [review]
Github pull request
Guillaume - What do you think, could you take a look and review it if you are happy with the approach? I tried using it for the browser chrome and it appeared to work quite well. I think using a web component for this would clean up our CSS in the system app and other apps quite a bit.
Attachment #8474262 -
Flags: review?(gmarty)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8474262 [details] [review]
Github pull request
Everything looks good to me except a comment left on Github. Also that'd be nice to use it for determinate progress bars (the ones with max and value attributes). The styling is slightly different than indeterminate. However this needs to be achieved using JavaScript and mutation observer or using a real <progress> element.
But this can be done in a subsequent version, so r+ing for now.
Attachment #8474262 -
Flags: review?(gmarty) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to gmarty from comment #3)
> Comment on attachment 8474262 [details] [review]
> Github pull request
>
> Everything looks good to me except a comment left on Github. Also that'd be
> nice to use it for determinate progress bars (the ones with max and value
> attributes). The styling is slightly different than indeterminate. However
> this needs to be achieved using JavaScript and mutation observer or using a
> real <progress> element.
Thanks. I agree with this. The only thing preventing us from doing this is bug 1054773. Hopefully we can get that fixed and use a real <progress> element.
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
You need to log in
before you can comment on or make changes to this bug.
Description
•