1054821 - Follow-up of bug 1024298: Remove no-longer-used |langIndependentLayouts|

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

This bug will do the issue 1 in the tracking bug 1054145:

Removal of langIndependentLayouts-related data structure and logics: langIndependentLayouts data structure was removed from keyboard-layouts.json: https://github.com/mnjul/gaia/commit/8763293e39d5121000c3b9b76b1583865442ae39#diff-53 in bug 1024298. Let's remove related logics altogether.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Let's have it tested.

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8474331 [details] [review]
Patch (PR @ GitHub)

Hi Yuren,

As the removal of |langIndependentLayouts| modifies several build-related scripts, please see if the patch looks good to you.

And Rudy, KeyboardHelper is also modified a bit, please review.

Thanks to both of you!

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8474331 [details] [review]
Patch (PR @ GitHub)

r=yurenju if unit test for build system pass, you can use |make build-test-unit| to execute it and this bug has been fixed on bug 1054822, rebase can fix this issue.

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Thanks Yuren. For the record: |make build-test-unit| passes with this patch (after rebasing, which is not yet pushed to my PR)

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8474331 [details] [review]
Patch (PR @ GitHub)

I would prefer we keep this feature as is, because someday we may need it.
e.g. the emoji layout would be one candidate for this.

I'll clear the review first.

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

bug 1024298 got reverted and wontfix'ed, so these bugs are invalid now.