1054827 - [FTU][FTE] "Enter PIN code" for SIM2 page flashing and keypad not shown after flashing stops

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Eric Chang [:ericcc] [:echang]]

### STR
1. Have 2 SIMs insta
2. Flash phone or 'Reset phone' from 'Settings' -> 'Device Information'
3. Enter FTU

### Actual 
Page flashing, '<' diappears and shows, keypad not shown
http://youtu.be/_Nv_TaXI2U4

### Expected
Page render as SIM1, not flashing, keypad shown, does not require user tapping on text box

###
v2.0 Flame
Gaia      8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/4bd4b0ae7bbe
BuildID   20140721000201
Version   32.0a2
ro.build.version.incremental=eng.ericcc.20140815.103628
ro.build.date=Fri Aug 15 10:36:36 CST 2014

v2.1 Flame
Gaia      aa8aace12d65956dd9525da5dac66e0d3b28597f
Gecko     https://hg.mozilla.org/mozilla-central/rev/37ac55a26014
BuildID   20140817160201
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Possible regression from bug 949439, since that had to do with showing the progress bar on SIM pages in FTU.

Comment 3

[Cody Roesch [:croesch]]

This bug repro's on: Flame 2.1, Flame 2.0

Actual Results: A lot of screen flashing occurs when the user enters the pin code for SIM 1 and both SIMs have pin codes. The keyboard disappears for the second SIM.

Repro Rate: 2/2

Environmental Variables:
Device: Flame Master
BuildID: 20140818124915
Gaia: 778c39b5597ea424d6a75934221265423ab3c9e7
Gecko: 72e6c0e8f66c
Version: 34.0a1 (Master) 
Firmware Version: v123
------------------------------------------------
Environmental Variables:
Device: Flame 2.0
BuildID: 20140818125116
Gaia: 1a215917df01bb815811f33665bd3fdca4130708
Gecko: 56322a357f6e
Version: 32.0 (2.0) 
Firmware Version: v123

------------------------------------------------
------------------------------------------------

This bug does NOT repro on: Flame 1.4

Actual Result: No flashing issue occurs between the screens for SIM 1 and SIM 2 pin entry screens.

Repro Rate: 0/3 attempts

Environmental Variables:
Device: Flame 1.4
BuildID: 20140818062816
Gaia: 21bec64497dc06a7f12071d573570ba8fea598ae
Gecko: 07d78d0f9bef
Version: 30.0 (1.4) 
Firmware Version: v123

Comment 4

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: looks very bad visually, encountered in FTU sets the users initial impression poorly - if they are using 2 sims

Comment 5

[Chris Kreinbring [:CKreinbring]]

Regression window
Last working
BuildID: 20140716171013
Gaia: d29773d2a011825fd77d1c0915a96eb0911417b6
Gecko: 8e8f3ba64655
Platform Version: 33.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken
BuildID: 20140716172339
Gaia: 5edca8cd06409b8bf404de4adf7ea08fc2940fd7
Gecko: a74600665875
Platform Version: 33.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Working Gaia / Broken Gecko = No repro
Gaia: d29773d2a011825fd77d1c0915a96eb0911417b6
Gecko: a74600665875
Broken Gaia / Working Gecko = Repro
Gaia: 5edca8cd06409b8bf404de4adf7ea08fc2940fd7
Gecko: 8e8f3ba64655
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/d29773d2a011825fd77d1c0915a96eb0911417b6...5edca8cd06409b8bf404de4adf7ea08fc2940fd7


B2G-inbound
Last working
BuildID: 20140716012802
Gaia: 0a57f4de494f79e7fae50c8a11066c3eb34b3bd4
Gecko: 8a61cf67dd41
Platform Version: 33.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken
BuildID: 20140716013201
Gaia: d74dd8f351866264f198985a9414633e957dbfff
Gecko: 7991e97af1dd
Platform Version: 33.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Working Gaia / Broken Gecko = No repro
Gaia: 0a57f4de494f79e7fae50c8a11066c3eb34b3bd4
Gecko: 7991e97af1dd
Broken Gaia / Working Gecko = Repro
Gaia: d74dd8f351866264f198985a9414633e957dbfff
Gecko: 8a61cf67dd41
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/0a57f4de494f79e7fae50c8a11066c3eb34b3bd4...d74dd8f351866264f198985a9414633e957dbfff

Comment 6

[Joshua Mitchell (Inactive)]

Broken by bug 1031369 - Kyle?

Comment 7

[Manuel Casas Barrado [:mancas]]

Attachment: SIM2 page not flashing

The main problem was an asynchronous task that should be completed before launch the system unlock pin dialog. However this task was delayed and caused the appearance of system unlock pin dialog, and once the task is complete the dialog is closed causing the flashing screen

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Clearing my needinfo since it looks like this got taken care of (I've been having problems reproing due to dual sim being finnicky). Thanks Manuel!

Comment 9

[Fernando Campo (:fcampo)]

Comment on attachment 8478143 [details] [review]
SIM2 page not flashing

Even though the bug is seen during FTU, the code change is on the system app side, so I'm afraid I'm not entitled to give a r+ not being a peer, sorry. Maybe Alive can check it (or proxy it)

Also, it would be great if we could have unit tests for this.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8478143 [details] [review]
SIM2 page not flashing

r=me

Comment 11

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8478143 [details] [review]
SIM2 page not flashing

Review Alive again, since I've made some changes in unit tests.

Also, I want to ask if we must show sim pin dialog while FTU is running regardless of the system update

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Manuel Casas Barrado [:mancas] from comment #11)
> Comment on attachment 8478143 [details] [review]
> SIM2 page not flashing
> 
> Review Alive again, since I've made some changes in unit tests.
> 
> Also, I want to ask if we must show sim pin dialog while FTU is running
> regardless of the system update

We don't show sim pin dialog when ftu running because ftu has a sim pin UI as well.

But it might be a problem if system is updated and we are showing the updating ftu without its embedded sim pin UI. Though it's out of scope of this bug.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8478143 [details] [review]
SIM2 page not flashing

Hi Mancas, I read the code again and thanks for your work.

I wonder if we have better way to do here based on your finding:
* FtuLaucher should tell us(SimLock) it's running a fullFtu or upgradingFtu.
** https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/ftu_launcher.js#L179
** Since it has already check the version, let's put the isUprage under FtuLauncher for other module to check.
* If it's running but not upgrading(FtuLauncher.isFtuRunning() && !FtuLauncher.isUpgrading()), let's return early.

Could you make this change? Sorry for not catching the problem in last review.
Lemme know if you have problems. Thank you!

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #12)
> (In reply to Manuel Casas Barrado [:mancas] from comment #11)
> > Comment on attachment 8478143 [details] [review]
> > SIM2 page not flashing
> > 
> > Review Alive again, since I've made some changes in unit tests.
> > 
> > Also, I want to ask if we must show sim pin dialog while FTU is running
> > regardless of the system update
> 
> We don't show sim pin dialog when ftu running because ftu has a sim pin UI
> as well.
> 
> But it might be a problem if system is updated and we are showing the
> updating ftu without its embedded sim pin UI. Though it's out of scope of
> this bug.

Forget this comment, I think it's intentional to show ftu if we are upgrading.

Comment 15

[Fernando Campo (:fcampo)]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #14)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #12)
> > (In reply to Manuel Casas Barrado [:mancas] from comment #11)
> > > Comment on attachment 8478143 [details] [review]
> > > SIM2 page not flashing
> > > 
> > > Review Alive again, since I've made some changes in unit tests.
> > > 
> > > Also, I want to ask if we must show sim pin dialog while FTU is running
> > > regardless of the system update
> > 
> > We don't show sim pin dialog when ftu running because ftu has a sim pin UI
> > as well.
> > 
> > But it might be a problem if system is updated and we are showing the
> > updating ftu without its embedded sim pin UI. Though it's out of scope of
> > this bug.
> 
> Forget this comment, I think it's intentional to show ftu if we are
> upgrading.

Yeah, it's intentional as we need to show the new tutorial (if any).

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to [PTO 28/8 - 9/9] Fernando Campo (:fcampo) from comment #15)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #14)
> > (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #12)
> > > (In reply to Manuel Casas Barrado [:mancas] from comment #11)
> > > > Comment on attachment 8478143 [details] [review]
> > > > SIM2 page not flashing
> > > > 
> > > > Review Alive again, since I've made some changes in unit tests.
> > > > 
> > > > Also, I want to ask if we must show sim pin dialog while FTU is running
> > > > regardless of the system update
> > > 
> > > We don't show sim pin dialog when ftu running because ftu has a sim pin UI
> > > as well.
> > > 
> > > But it might be a problem if system is updated and we are showing the
> > > updating ftu without its embedded sim pin UI. Though it's out of scope of
> > > this bug.
> > 
> > Forget this comment, I think it's intentional to show ftu if we are
> > upgrading.
> 
> Yeah, it's intentional as we need to show the new tutorial (if any).

I see, but I mean we need to show sim pin dialog only if the ftu is upgrading.

Comment 17

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8478143 [details] [review]
SIM2 page not flashing

Hey Alive, please take a look at the commit. Thanks!

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8478143 [details] [review]
SIM2 page not flashing

r=me, thanks very much. Please note there is a master patch implements the nearly same thing in bug 1035250.

Michanel, could you specify when you will land so we don't have conflict?

Note: both isFtuUpgrading() or isUpgrading() works for me.

Comment 19

[Michael Henretty [:mikehenrty][:mhenretty]]

Thanks Alive for the heads up. I don't think it matters too much which patch lands first, the patches are pretty similar and conflicts should be easy.

I plan to land tomorrow after a UI review.

Comment 20

[Manuel Casas Barrado [:mancas]]

Master: https://github.com/mozilla-b2g/gaia/commit/c265595d90431e21e7bc82c936c4d9a6522be68c

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Note that due to recent policy changes, all B2G uplifts needs approval now regardless of blocking status. Please request v2.0 and v2.1 approval on this patch when you get a chance. Sorry for the inconvenience.

Comment 22

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8478143 [details] [review]
SIM2 page not flashing

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):Bug 1031369
[User impact] if declined: FTU sets the user's initial impression poorly - if they are using 2 sims
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]: No

Comment 23

[[:fabrice] Fabrice Desré]

(In reply to Manuel Casas Barrado [:mancas] from comment #22)
> Comment on attachment 8478143 [details] [review]
> SIM2 page not flashing
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #):Bug 1031369
> [User impact] if declined: FTU sets the user's initial impression poorly -
> if they are using 2 sims
> [Testing completed]:
> [Risk to taking this patch] (and alternatives if risky): No
> [String changes made]: No

There are no automated test or smoketests?

Comment 24

[Manuel Casas Barrado [:mancas]]

Yes, this bugs has is unit tests working as expected. Sorry for not complete that field

Comment 25

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/0c808a939741c515a70ab2d649b1e98a14d73f5e
v2.0: https://github.com/mozilla-b2g/gaia/commit/35533237253ff5a27e9301a9031c4cc4b1d95eb5

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Reverted from v2.0 for Mnw failures.
v2.0: https://github.com/mozilla-b2g/gaia/commit/59a670d40ad7f5966ec7fafcab0f05009bea97ab

https://tbpl.mozilla.org/php/getParsedLog.php?id=47609609&tree=Mozilla-B2g32-v2.0

Comment 27

[Manuel Casas Barrado [:mancas]]

I'm working in a patch for v2.0

Comment 28

[Manuel Casas Barrado [:mancas]]

Attachment: Patch for v2.0

Comment 29

[Fernando Campo (:fcampo)]

Comment on attachment 8487053 [details] [review]
Patch for v2.0

looks good for 2.0

Comment 30

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/41804faeb28b5aef10e160469742d96bb5deba48

Comment 31

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8487053 [details] [review]
Patch for v2.0

No need review.
Note there is already a mock_system in v2.0 https://github.com/mozilla-b2g/gaia/blob/v2.0/apps/system/test/unit/mock_system.js

Comment 32

[SandKing]

This issue has been verified successfully on Flame2.0&2.1&2.2
Verify video:"verify_1054827.mp4".

Flame2.0 build
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141202.034707
FW-Date         Tue Dec  2 03:47:18 EST 2014
Bootloader      L1TC00011880

Flame2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141202.034824
FW-Date         Tue Dec  2 03:48:34 EST 2014
Bootloader      L1TC00011880

Flame2.2 bulid:
Gaia-Rev        725685831f5336cf007e36d9a812aad689604695
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID        20141202040207
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141202.072347
FW-Date         Tue Dec  2 07:23:58 EST 2014
Bootloader      L1TC00011880

Comment 33

[SandKing]

Attachment: Verified video: verify_1054827.mp4