1035250 - [User Story] Show connectivity status during FTE

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

WIP: https://github.com/mikehenrty/gaia/tree/bug-1035250-fte-connectivity

Comment 4

[Gerry Chang [:gchang]]

Add the test cases.
https://moztrap.mozilla.org/manage/cases/?filter-suite=755

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] FTU with IAC to show progressive statusbar

Hi Alive, can you give me feedback on the IAC approach for showing statusbar icons as you progress through ftu?

(I know this needs squashed, registers multiple handlers for settings sometimes, fails tests, has curse words, etc. but this will all be cleaned up before review)

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8479626 [details] [review]
[Gaia PR] FTU with IAC to show progressive statusbar

Delay the settings listener seems not bad,
but I still prefer we always observe but not showing it initially. (Maybe a hidden class on the dom element by default.)

Could we:
* Have a list of initial hidden icons.
* Show all the icons once ftu is skipped/done.
* Show a specific icon according the IAC message.

Also please note:
* Since you have statusbar in ftu now, we should prevent rocketbar to be opened during ftu since this is not expected.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8479626 [details] [review]
[Gaia PR] FTU with IAC to show progressive statusbar

I'd like to get another round of feedback before the final review. Known issues are that I need to add unit tests for the iac stuff, and fix some marionette tests.

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #6)
> Comment on attachment 8479626 [details] [review]
> [Gaia PR] FTU with IAC to show progressive statusbar
> 
> Could we:
> * Have a list of initial hidden icons.

All the icons are hidden initially except battery. I added a comment to this effect in the code.

> * Show all the icons once ftu is skipped/done.

Done.

> * Show a specific icon according the IAC message.

Done.

> Also please note:
> * Since you have statusbar in ftu now, we should prevent rocketbar to be
> opened during ftu since this is not expected.

This is also done. There are two ways to trigger the rocketbar opening, one is to click on the search bar, the second is to click on the utility tray touch listener. The search bar is hidden with css, and the utility tray is disabled while we run FTU. So rocketbar will not be shown in FTU (unless you launch it later as a regular app).

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8479626 [details] [review]
[Gaia PR] FTU with IAC to show progressive statusbar

I have concern for ftu part; I hope we keep these two module as standalone as possible. See the comments and lemme know if you have problems.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8479626 [details] [review]
[Gaia PR] FTU with IAC to show progressive statusbar

Alive, can you take another look?

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8479626 [details] [review]
[Gaia PR] FTU with IAC to show progressive statusbar

r+ with nits

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8479626 [details] [review]
[Gaia PR] FTU with IAC to show progressive statusbar

Nits addressed. Rob, can you take a look at this?

Comment 12

[Rob MacDonald [:robmac]]

Comment on attachment 8479626 [details] [review]
[Gaia PR] FTU with IAC to show progressive statusbar

I'll let Jacqueline decide on the flag as she's the approver. 

My main comment is that no notifications indicator should be shown (icon or ambient) as the utility tray cannot be opened and notifications cannot be accessed. Based on Michael's irc comments, this sounds like a regression of some sort.

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Rob MacDonald [:robmac] from comment #12)
> Comment on attachment 8479626 [details] [review]
> [Gaia PR] FTU with IAC to show progressive statusbar
> 
> I'll let Jacqueline decide on the flag as she's the approver. 
> 
> My main comment is that no notifications indicator should be shown (icon or
> ambient) as the utility tray cannot be opened and notifications cannot be
> accessed. Based on Michael's irc comments, this sounds like a regression of
> some sort.

Yup, that's a bug we can polish up after FL.

Comment 14

[Jacqueline Savory [:jsavory] UX]

Comment on attachment 8479626 [details] [review]
[Gaia PR] FTU with IAC to show progressive statusbar

This is looking great to me! 
The only change I would make aside from the ones previously mentioned is to have the wifi indicator appear as soon as the connection is established rather than when the user taps to the next page. However, this is a nice to have and would be more of a polish item.

Comment 15

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/0bf1094ab2917559a291c98242bdffab1fec9dd2

Comment 16

[Kevin Grandon :kgrandon]

I had to back this out due to failures on b2g-inbound. It looks like it was not failing on gaia-try, but perhaps it's landing in conjunction with another bug caused failures?

https://tbpl.mozilla.org/php/getParsedLog.php?id=47089050&tree=B2g-Inbound

https://github.com/mozilla-b2g/gaia/commit/807578c629c37f832506b65c876bf0ab969d5f51

I'll help look at this once the tree is green.

Comment 17

[Kevin Grandon :kgrandon]

It seems like this in combination with the utility tray refresh cause the utility tray to be dragged down as well when you swipe down, so our tests caught a real bug.

Comment 18

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey Mike - I think that this will probably fix it. The problem is that the statusbar/utility tray depend on touch event listener ordering. If this works feel free to land it however you see fit.

Here is the fix for the tests: https://github.com/KevinGrandon/gaia/commit/5dca8f1a3cb4b51971d45a8c5f1b5bde015eddd3

Comment 19

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8481815 [details] [review]
Github pull request

Thanks for that Kevin.

Comment 20

[Michael Henretty [:mikehenrty][:mhenretty]]

We have a lot of intermittents on Gij, but there is a green run on the PR so I'm relanding.

Comment 21

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/d424dc89d8c1e790b311cec3ab3adb3e3d388406

Comment 22

[[:SalvadorR]]

This issue is verified fixed on Flame 2.1(319mb)

Flame 2.1(319mb)

Environmental Variables:
Device: Flame Master (319mb)
BuildID: 20140902040205
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: c360f3d1c00d
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

STR
1. Initiate First Time Use in settings
2. Go through every page on FTU including links requiring internet to connect to
3. Observe the Status bar Icons

Actual: Status of internet shows correctly on status bar

Comment 23

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Spec 2.1] FTE with Connectivity

Adding spec so I can link to it from other bugs.

Comment 24

[KTucker [:KTucker][Inactive 3/4/2016]]

Please disregard comment 22

This issue cannot be verified at this time because this two issues have not been resolved:

bug 1062753 (Empty SIM 1 & SIM 2 icons are not shown in title bar in FTE when all SIM cards are taken out) 

bug 1062998 (SIM signal statusbar icons should appear on SIM Manager screen)

Comment 25

[Gerry Chang [:gchang]]

Verified @
Gaia      fbb297c39aab5f17b179533d2a9a6c5166b2c197
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/fb5e796da813
BuildID   20140903000204
Version   34.0a2