Closed Bug 1054889 Opened 10 years ago Closed 10 years ago

[Text selection] Update images for touch caret and selection carets

Categories

(Core :: DOM: Selection, defect)

Product:
Core
Component:
DOM: Selection
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file, 2 obsolete files)

Update images for touch caret and selection carets. r=roc, f=mtseng (v3, carry r+, f+)
62.58 KB, patch
TYLin
: review+
Carol
: ui-review+
Details | Diff | Splinter Review 
The images for touch caret and selection carets had been updated by using SVG images in bug 1021527. However, it makes Gip timeout-prone (bug 1046635), and it had been backout in [1]. We should update the latest png images provided in [2]

[1] https://hg.mozilla.org/mozilla-central/rev/c3ab83f45b5d
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1023688#c3
Update images provided in bug 1024930, and make touch caret uses the
same images as selection carets.
Attachment #8474383 - Flags: feedback?(mtseng)
Comment on attachment 8474383 [details] [diff] [review]
Update images for touch caret and selection carets.

Review of attachment 8474383 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8474383 - Flags: feedback?(mtseng) → feedback+
Attachment #8474383 - Flags: review?(roc)
Carol, would you like to have a UI review?
Flags: needinfo?(chuang)
Remove text_selection_handle lines from package-manifest.in since those images are deleted.
Attachment #8475001 - Flags: review+
Hi Ting-Yu,
Please see Bug 1023688 for the new caret asset. please update the new images.
could I have a UI review once you're done with the image update? Thank you!
Flags: needinfo?(chuang) → needinfo?(tlin)
Carol, I'll update the latest images and get back to you.
Flags: needinfo?(tlin)
Update the latest caret images provided in Bug 1023688.
Attachment #8474383 - Attachment is obsolete: true
Attachment #8475001 - Attachment is obsolete: true
Attachment #8475035 - Flags: review+
Hi Carol, would please do a UI review? Thanks.
Flags: needinfo?(chuang)
Attachment #8475035 - Flags: ui-review?(chuang)
Attachment #8475035 - Flags: ui-review?(chuang) → ui-review+
Flags: needinfo?(chuang)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9f20a7ec2c1e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: