Closed
Bug 1054949
Opened 10 years ago
Closed 7 years ago
App screenshots should rotate to fit the current orientation
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: etienne, Unassigned)
References
Details
(Whiteboard: [systemsfe])
This wasn't implemented in the 2.0 time frame for the edge gestures.
But it's definitely going to be needed for the 2.1 task switcher.
Currently when the screenshot doesn't match the current orientation we just hide it.
Updated•10 years ago
|
Assignee: nobody → sfoster
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S5 (26sep)
Comment 1•10 years ago
|
||
I think for 2.1 it's already late so let's plan this for 2.2
My 2$
* Implement ScreenshotController as one sub component of the AppWindow
* Move all screenshot overlay related stuff into the ScreenshotController.
* Rotate(by CSS) when the screenshotOverlay has different dimension with the current device dimension.
Updated•10 years ago
|
Target Milestone: 2.1 S5 (26sep) → ---
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #1)
> I think for 2.1 it's already late so let's plan this for 2.2
>
> My 2$
> * Implement ScreenshotController as one sub component of the AppWindow
> * Move all screenshot overlay related stuff into the ScreenshotController.
> * Rotate(by CSS) when the screenshotOverlay has different dimension with the
> current device dimension.
We need to rotate the titlebar/chromebar too... So there's also some issues with the appWindow element itself not being resized currently (for good reasons).
To do this efficiently we might have to resize the element but not the iframe nor the screenshot which should also be rotated. Fun :)
Anyway I wouldn't start with a ScreenshotController since the issue might be wider than "screenshots". And I have a feeling the "screenshot part" might not be big enough to justify a dedicated controller.
Comment 3•10 years ago
|
||
(In reply to Etienne Segonzac (:etienne) from comment #2)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #1)
> > I think for 2.1 it's already late so let's plan this for 2.2
> >
> > My 2$
> > * Implement ScreenshotController as one sub component of the AppWindow
> > * Move all screenshot overlay related stuff into the ScreenshotController.
> > * Rotate(by CSS) when the screenshotOverlay has different dimension with the
> > current device dimension.
>
> We need to rotate the titlebar/chromebar too... So there's also some issues
> with the appWindow element itself not being resized currently (for good
> reasons).
> To do this efficiently we might have to resize the element but not the
> iframe nor the screenshot which should also be rotated. Fun :)
Maybe AppWindow.prototype._resize could change to resize this.browser.element as well as this.element (is there 2 reflow?)
And we need another argument to tell it to only resize this.element
> Anyway I wouldn't start with a ScreenshotController since the issue might be
> wider than "screenshots". And I have a feeling the "screenshot part" might
> not be big enough to justify a dedicated controller.
I don't insist on it.
Updated•10 years ago
|
blocking-b2g: --- → 2.2?
Comment 5•10 years ago
|
||
We are not going to block 2.2 on portrait mode task manager anymore.
blocking-b2g: 2.2? → ---
Comment 6•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•