Closed Bug 1054949 Opened 8 years ago Closed 5 years ago

App screenshots should rotate to fit the current orientation

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: etienne, Unassigned)

References

Details

(Whiteboard: [systemsfe])

This wasn't implemented in the 2.0 time frame for the edge gestures.

But it's definitely going to be needed for the 2.1 task switcher.

Currently when the screenshot doesn't match the current orientation we just hide it.
Depends on: 1067309
Depends on: 1068925
Assignee: nobody → sfoster
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S5 (26sep)
I think for 2.1 it's already late so let's plan this for 2.2

My 2$
* Implement ScreenshotController as one sub component of the AppWindow
* Move all screenshot overlay related stuff into the ScreenshotController.
* Rotate(by CSS) when the screenshotOverlay has different dimension with the current device dimension.
Target Milestone: 2.1 S5 (26sep) → ---
Blocks: 1068925
No longer depends on: 1068925
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #1)
> I think for 2.1 it's already late so let's plan this for 2.2
> 
> My 2$
> * Implement ScreenshotController as one sub component of the AppWindow
> * Move all screenshot overlay related stuff into the ScreenshotController.
> * Rotate(by CSS) when the screenshotOverlay has different dimension with the
> current device dimension.

We need to rotate the titlebar/chromebar too... So there's also some issues with the appWindow element itself not being resized currently (for good reasons).
To do this efficiently we might have to resize the element but not the iframe nor the screenshot which should also be rotated. Fun :)

Anyway I wouldn't start with a ScreenshotController since the issue might be wider than "screenshots". And I have a feeling the "screenshot part" might not be big enough to justify a dedicated controller.
(In reply to Etienne Segonzac (:etienne) from comment #2)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #1)
> > I think for 2.1 it's already late so let's plan this for 2.2
> > 
> > My 2$
> > * Implement ScreenshotController as one sub component of the AppWindow
> > * Move all screenshot overlay related stuff into the ScreenshotController.
> > * Rotate(by CSS) when the screenshotOverlay has different dimension with the
> > current device dimension.
> 
> We need to rotate the titlebar/chromebar too... So there's also some issues
> with the appWindow element itself not being resized currently (for good
> reasons).
> To do this efficiently we might have to resize the element but not the
> iframe nor the screenshot which should also be rotated. Fun :)

Maybe AppWindow.prototype._resize could change to resize this.browser.element as well as this.element (is there 2 reflow?)
And we need another argument to tell it to only resize this.element

> Anyway I wouldn't start with a ScreenshotController since the issue might be
> wider than "screenshots". And I have a feeling the "screenshot part" might
> not be big enough to justify a dedicated controller.

I don't insist on it.
Not currently working on this
Assignee: sfoster → nobody
blocking-b2g: --- → 2.2?
We are not going to block 2.2 on portrait mode task manager anymore.
blocking-b2g: 2.2? → ---
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.