Need to add a tone player helper

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jaoo, Assigned: jaoo)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

A tone player object helper will improve the UX a lot by playing the tones for all call states such as dialing, busy, on hold, etc.
(Assignee)

Updated

4 years ago
Assignee: nobody → josea.olivera
(Assignee)

Updated

4 years ago
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
(Assignee)

Comment 2

4 years ago
Comment on attachment 8474823 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/89

Basic tone player. ATM playing the dial tone when dialing. Lets land this and play the call held tone once bug 1043971 lands. Other tones such busy can be added in follow-up bugs. Would you mind to have a look please? Thanks!
Attachment #8474823 - Flags: review?(borja.bugzilla)
Comment on attachment 8474823 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/89

Great job!!! With this new set of sounds the app looks great!
Attachment #8474823 - Flags: review?(borja.bugzilla) → review+
(Assignee)

Comment 4

4 years ago
(In reply to Borja Salguero [:borjasalguero] from comment #3)
> Comment on attachment 8474823 [details] [review]
> Pointer to Github PR
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/89
> 
> Great job!!! With this new set of sounds the app looks great!

Thanks for the review. Landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/69193d60828ee9d46377cd3a1217510df719f037
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1007681
(Assignee)

Updated

3 years ago
See Also: → bug 1060751
You need to log in before you can comment on or make changes to this bug.