1054962 - Need to add a tone player helper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

A tone player object helper will improve the UX a lot by playing the tones for all call states such as dialing, busy, on hold, etc.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/89

WIP

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8474823 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/89

Basic tone player. ATM playing the dial tone when dialing. Lets land this and play the call held tone once bug 1043971 lands. Other tones such busy can be added in follow-up bugs. Would you mind to have a look please? Thanks!

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8474823 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/89

Great job!!! With this new set of sounds the app looks great!

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Borja Salguero [:borjasalguero] from comment #3)
> Comment on attachment 8474823 [details] [review]
> Pointer to Github PR
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/89
> 
> Great job!!! With this new set of sounds the app looks great!

Thanks for the review. Landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/69193d60828ee9d46377cd3a1217510df719f037