1055154 - Add finer-grained LSan suppressions for WebRTC leaks

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Andrew McCreight [:mccr8]]

The largest remaining set up LSan-detected leaks are from WebRTC. Right now, we have very coarse-grained LSan suppressions:
  leak:/media/mtransport/
  leak:/media/webrtc/signaling/

This means that any leak that has code from those directories in it will be ignored by LSan. I'm going to come up with a larger set of suppressions that will cover our WebRTC leaks. This should help prevent large regressions, and will hopefully illuminate exactly what sort of leaks remain.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: new suppression list, WIP

Working locally with my suppression analysis script, this seems to cover everything.  Some of it is init stuff that is probably held alive until shut down anyways, but some of it looks like real leaks.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Add finer-grained LSan suppressions for WebRTC leaks.

try run: https://tbpl.mozilla.org/?tree=Try&rev=bb3abc6fea78

The leak in the first M1 run is an existing intermittent.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8475200 [details] [diff] [review]
Add finer-grained LSan suppressions for WebRTC leaks.

Review of attachment 8475200 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 4

[Andrew McCreight [:mccr8]]

landed DONTBUILD

https://hg.mozilla.org/integration/mozilla-inbound/rev/94d8ee70f149

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/94d8ee70f149

Comment 6

[Andrew McCreight [:mccr8]]

I landed some additional suppressions for the intermittent leak in bug 1055910 with rs from jesup over IRC.

https://hg.mozilla.org/integration/mozilla-inbound/rev/78cd1b0af0c0

Comment 7

[Andrew McCreight [:mccr8]]

I didn't read the list of intermittent leaks closely enough, so I had to add some more:

https://hg.mozilla.org/integration/mozilla-inbound/rev/72f6354159d5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/78cd1b0af0c0

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/72f6354159d5

Comment 10

[Andrew McCreight [:mccr8]]

And some more, for intermittent WebRTC leaks that showed up yesterday...

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7e28d7d7505

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d7e28d7d7505