1055187 - crash in mozilla::NfcEventRunnable::Run()

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat.txt

This bug was filed from the Socorro interface and is 
report bp-bd8e09bc-eafd-4930-a917-65f902140818.
=============================================================

[B2G][Flame][NFC]Crash when receiving a contact through NFC in low memory environments
  
Description:
When a user receives a Contact through NFC the phone will crash.
   
Repro Steps:
1) Update a Flame device to BuildID: 20140818040201
2) Set memory on the device to 319mb and restart it
3) Receive a contact from another phone
3) Observe Crash
  
Actual:
A crash occurs when a contact is received
  
Expected: 
It is expected that the phone does not crash when a contact is received
  
Environmental Variables:
Device: Flame 2.1 Master (319mb)
BuildID: 20140818040201
Gaia: aa8aace12d65956dd9525da5dac66e0d3b28597f
Gecko: 0aaa2d3d15cc
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0
  
Repro frequency: 90%
Link to failed test case: https://moztrap.mozilla.org/manage/case/13957/
See attached: video clip(http://youtu.be/CiDZPERHqNg), logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue does not occur on 2.1 Flame (512mb) or 2.0 Flame.

Environmental Variables:
Device: Flame 2.1 Master (512mb)
BuildID: 20140818040201
Gaia: aa8aace12d65956dd9525da5dac66e0d3b28597f
Gecko: 0aaa2d3d15cc
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0 (319mb)
BuildID: 20140818000201
Gaia: fb2dd31abed2803eb7ad67eb4c52abb48de1e0f7
Gecko: 09f7a7184c71
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Result:
The contact was received correctly.

---------------------------------------------------------------------
The NFC feature does not exist in 1.4 Flame or on Buri Devices.

Environmental Variables:
Device: Flame 1.4 (319mb)
Build ID: 20140818063007
Gaia: 21bec64497dc06a7f12071d573570ba8fea598ae
Gecko: 07d78d0f9bef
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Result:
NFC is not usable.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a regression from 2.0 and is a crash so nominating 2.1?

Comment 3

[Chris Kreinbring [:CKreinbring]]

Regression window
Last working
BuildID: 20140730045709
Gaia: 25e998814ba89f30fe44cd2fdfbb44d160a04641
Gecko: 08c23f12a43e
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken
BuildID: 20140730124313
Gaia: b67ddd7d40b52e65199478b8d6631c2c28fdf41d
Gecko: b3cbce8a2b87
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Working Gaia / Broken Gecko = Repro
Gaia: 25e998814ba89f30fe44cd2fdfbb44d160a04641
Gecko: b3cbce8a2b87
Broken Gaia / Working Gecko = No repro
Gaia: b67ddd7d40b52e65199478b8d6631c2c28fdf41d
Gecko: 08c23f12a43e
Gecko pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=08c23f12a43e&tochange=b3cbce8a2b87


B2G-inbound
Last working
BuildID: 20140730024304
Gaia: 29a58ec654e598926409c382c9f3b5db3726947a
Gecko: 1aec72f99110
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken
BuildID: 20140730032304
Gaia: 29a58ec654e598926409c382c9f3b5db3726947a
Gecko: 127ca52e4cce
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Working Gaia / Broken Gecko = Repro
Gaia: 29a58ec654e598926409c382c9f3b5db3726947a
Gecko: 127ca52e4cce
Broken Gaia / Working Gecko = No Repro
Gaia: 29a58ec654e598926409c382c9f3b5db3726947a
Gecko: 1aec72f99110
Gecko pushlog: http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=1aec72f99110&tochange=127ca52e4cce

Comment 4

[Joshua Mitchell (Inactive)]

Possibly broken by bug 933588 - can you take a look Yoshi?

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I am already working on it.

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: crash, regression

Comment 7

[Alison Shiue]

Update another similar finding:
Device    Flame 2.1 (default memory)
Gaia      a47ecb6368c015dd72148acde26413fd90ba3136
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/c1e0cea51571
BuildID   20140904160202
Version   34.0a2
Firmware Version: v123

STR: 
1. Device receives multiple websites(maybe 10 times) via NFC

Expect result:
Nothing special

Actual result:
Device crashed

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Firmware v122 and v123 uses older nfcd, which will send fragmented data.
The master branch of nfcd already fixes this.

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Can QA test this again with nfcd v2.1 branch?
https://github.com/mozilla-b2g/platform_system_nfcd/tree/v2.1
The nfcd from V122 and V123 are from older version and this problem should be fixed already.


Thanks

Comment 11

[Joshua Mitchell (Inactive)]

QA-Wanted to re-test in the 2.1 branch and also check the 2.2 (master) branch

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

ni? for the QA for comment 10

Comment 13

[Chris Kreinbring [:CKreinbring]]

The bug does not repro on Flame 2.2 or Flame 2.1 with KK base and 319 MB.
Actual results: Receiving a contact through NFC transfers the contact to the device with no errors.

Flame 2.2
BuildID: 20140915053010
Gaia: 855be6ade407c26e0596e7306a44deebc3f60933
Gecko: 56cba2986c61
Platform Version: 35.0a1
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1
BuildID: 20140915073605
Gaia: 944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko: 2697f51cfe95
Platform Version: 34.0a2
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Comment 14

[Joshua Mitchell (Inactive)]

As comment 10 indicates - this issue is fixed in the new base (KK) - (verified in comment 13).

Comment 15

[Alison Shiue]

Change to "VERIFIED FIXED" based on comment 13 and also verified on
Gaia-Rev        86905e14c3ff06a0e6952ba635b6066ad2eea6b4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/572b666c54bd
Build-ID        20140925160208
Version         34.0a2

Comment 16

[Lance（leave from Mozilla）]

According to comment 14 and comment 15, change status-b2g-v2.1 and status-b2g-v2.2 to verified.