1055341 - Sync preferences pane has orphaned misplaced help/[?] image/link

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: sync-prefs.png

See attached image - there is a stray [?] image way to the right and bottom of the pane.  It ends up opening https://support.mozilla.org/en-US/kb/how-do-i-set-up-firefox-sync?redirectlocale=en-US&as=u&redirectslug=How+to+sync+Firefox+settings+between+computers&utm_source=inproduct

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

From in-content preference triage today: Removing this as a blocker for shipping in-content prefs. We should fix it, but it is not going to block us from shipping.

Comment 2

[Manish Goregaokar [:manishearth]]

Marking as good first bug candidate. I wasn't able to figure out the problem after poking at it with the devtools a bit (my XUL is rusty). Jared, have any idea how this should be solved?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

When Mark used the words "stray", I believe he was describing how far away the Help button is from the rest of the UI. Unfortunately, there isn't an easy solution to this problem, as the Sync pane uses a <xul:deck> to display the relevant sync-preferences view. <xul:deck>'s are displayed at the size of their largest pane, and in the case of a user who doesn't have Sync configured, this leaves a lot of whitespace at the bottom.

It is possible that we could ditch the <xul:deck> and just go with setting .hidden=true on the <xul:vbox> children of #weavePrefsDeck. Blair, what do you think about doing that? If we go this route, we can add steps to make this a good-first-bug.

Comment 4

[Manish Goregaokar [:manishearth]]

Yeah, I'd figured out what he meant but I wasn't able to debug why it happened (didn't know the behavior of <deck>.


I think replacing it with a a JS solution sounds good. Alternatively, we can make multiple copies of the help button (I don't like this solution though) for each vbox.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> It is possible that we could ditch the <xul:deck> and just go with setting
> .hidden=true on the <xul:vbox> children of #weavePrefsDeck. Blair, what do
> you think about doing that? If we go this route, we can add steps to make
> this a good-first-bug.

Yes please. We need to move away from using a deck regardless of this bug - it forces a design/flow that doesn't fit with in-content prefs.

Comment 6

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 39.0a1 (buildID: 20150309030224).