1055393 - [EME] Unit tests for GMPStorage

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We need unit tests for GMPStorage.

We need automated tests that test at least that:
* Reading an empty record returns 0 bytes.
* Writing and then reading a records work.
* Writing a record replaces its contents, truncating the length of the record to the new record's length. The new record's length can be 0.
* Storage for other origins should not be accessible.
* Storage works during async shutdown.
* Records cannot be opened by multiple clients at once.
* Using GMPStorage from non main thread fails.
* Private Browsing mode is respected. (Not sure if this is possible in a gtest.)

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Add gtests for GMPStorage

Add continnuation-hell gtests for GMPStorage, including verifying private browsing mode and node id generation.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

A few more details about the patch/tests:

* We send messages from parent to child GMP through GMPDecryptor, in order to instruct the child process which APIs to exercise and how.
* There's a basic "write some data etc" test that the child runs relatively autonomously, and other patches that test cross origin and PB mode which are driven from the parent.

Jesup: Are you OK with me adding a GMPDecryptor interface to the gmp-fake plugin that tests GMPStorage, rather than being a functioning decryptor?

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Sure

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

try -a:
https://tbpl.mozilla.org/?tree=Try&rev=3e91ff2d58af

And hopefully with the B2G ICS Emulator build failure fixed:
https://tbpl.mozilla.org/?tree=Try&rev=59c9838064ae

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch v2: Updated for async gmp-clear-storage-complete notification

Updated patch on top of changes in bug 1060192, as the gmp-clear-storage operation is no longer blocking, we have to wait for a gmp-clear-storage-complete notification before we can assume storage is cleared.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=359d5b580d3b
https://tbpl.mozilla.org/?tree=Try&rev=359d5b580d3b

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

s/override/MOZ_OVERRIDE/g
https://tbpl.mozilla.org/?tree=Try&rev=2bf4d88af680

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Missed a couple of 'override's...
https://tbpl.mozilla.org/?tree=Try&rev=8f7ee5302793

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83667d52bfa1

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/83667d52bfa1

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

Mass update firefox-status to track EME uplift.