Rename TabsPanel internal class from TabsListContainer to PanelViewContainer

RESOLVED FIXED in Firefox 35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mhaigh, Assigned: mhaigh)

Tracking

unspecified
Firefox 35
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-larch])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
There are too many usages of the word tab, we should refactor this to accurately describe what it is
(Assignee)

Comment 1

4 years ago
Created attachment 8475215 [details] [diff] [review]
bug 1055539 - Rename TabsPanel internal class from TabsListContainer to PanelViewContainer
Attachment #8475215 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8475215 [details] [diff] [review]
bug 1055539 - Rename TabsPanel internal class from TabsListContainer to PanelViewContainer

Review of attachment 8475215 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with the nits fixed.

::: mobile/android/base/tabs/TabsPanel.java
@@ +251,4 @@
>          return mActivity.onOptionsItemSelected(item);
>      }
>  
> +    private static int getTabContainerHeight(PanelViewContainer listContainer) {

nits:
getTabContainerHeight -> getPanelsContainerHeight
listContainer -> panelsContainer

For consistency.
Attachment #8475215 - Flags: review?(lucasr.at.mozilla) → review+
(Assignee)

Comment 3

4 years ago
oops - pushed to larch by mistake

http://hg.mozilla.org/projects/larch/rev/8db4bd78932d
Whiteboard: [fixed-larch]
https://hg.mozilla.org/mozilla-central/rev/63af113825cb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.