1055539 - Rename TabsPanel internal class from TabsListContainer to PanelViewContainer

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

There are too many usages of the word tab, we should refactor this to accurately describe what it is

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: bug 1055539 - Rename TabsPanel internal class from TabsListContainer to PanelViewContainer

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8475215 [details] [diff] [review]
bug 1055539 - Rename TabsPanel internal class from TabsListContainer to PanelViewContainer

Review of attachment 8475215 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with the nits fixed.

::: mobile/android/base/tabs/TabsPanel.java
@@ +251,4 @@
>          return mActivity.onOptionsItemSelected(item);
>      }
>  
> +    private static int getTabContainerHeight(PanelViewContainer listContainer) {

nits:
getTabContainerHeight -> getPanelsContainerHeight
listContainer -> panelsContainer

For consistency.

Comment 3

[Martyn Haigh (:mhaigh)]

oops - pushed to larch by mistake

http://hg.mozilla.org/projects/larch/rev/8db4bd78932d

Comment 4

[Martyn Haigh (:mhaigh)]

Backed out of larch

https://hg.mozilla.org/integration/fx-team/rev/63af113825cb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/63af113825cb