Closed Bug 1055676 (ruby-align) Opened 5 years ago Closed 5 years ago

implement CSS 'ruby-align' property

Categories

(Core :: Layout: Block and Inline, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: dbaron, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(5 files)

I'm filing this as a bug on implementing the CSS ruby-align property:
http://dev.w3.org/csswg/css-ruby/#ruby-align-property

I think we probably don't need to do this in order to ship CSS Ruby, although I'm willing to entertain arguments to the contrary.
Assignee: nobody → quanxunzhen
Status: NEW → ASSIGNED
I'm going to implement the actually alignment inside PropertyProvider of nsTextFrame. The reason is that we have to expand spacing of characters instead of only the width of frames, so that the continuity of selection can be kept.
Blocks: enable-css-ruby
No longer blocks: css-ruby
Depends on: 1063857, 1055665
I'm going to merge nsRuby{Base,Text}Frame to one super class, as behaviors of them are mostly identical in the given box model. What do you think is the proper name for that class? Maybe nsRubyContentFrame or something?
Flags: needinfo?(dbaron)
It might make sense to use nsRubyTextFrame as the common name, although I'd be ok with nsRubyContentFrame.
Flags: needinfo?(dbaron)
Blocks: 1081770
Depends on: 1107721
Depends on: 1108429
Blocks: css-ruby
No longer blocks: enable-css-ruby
No longer depends on: 1107721
No longer blocks: 1081770
We probably need to implement this before implementing inter-character ruby.
Attachment #8564796 - Flags: review?(roc)
Comment on attachment 8564792 [details] [diff] [review]
patch 1 - Parse and compute ruby-align

Review of attachment 8564792 [details] [diff] [review]:
-----------------------------------------------------------------

Better get someone else to review style system patches :-)
Attachment #8564792 - Flags: review?(roc) → review?(cam)
Comment on attachment 8564792 [details] [diff] [review]
patch 1 - Parse and compute ruby-align

Review of attachment 8564792 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsComputedDOMStyle.cpp
@@ +3077,5 @@
>  
>  CSSValue*
> +nsComputedDOMStyle::DoGetRubyAlign()
> +{
> +  nsROCSSPrimitiveValue *val = new nsROCSSPrimitiveValue;

"*" next to type please.
Attachment #8564792 - Flags: review?(cam) → review+
Blocks: 1133624
Depends on: 1138092
You need to log in before you can comment on or make changes to this bug.