1055676 - (ruby-align) implement CSS 'ruby-align' property

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm filing this as a bug on implementing the CSS ruby-align property:
http://dev.w3.org/csswg/css-ruby/#ruby-align-property

I think we probably don't need to do this in order to ship CSS Ruby, although I'm willing to entertain arguments to the contrary.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

I'm going to implement the actually alignment inside PropertyProvider of nsTextFrame. The reason is that we have to expand spacing of characters instead of only the width of frames, so that the continuity of selection can be kept.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

I'm going to merge nsRuby{Base,Text}Frame to one super class, as behaviors of them are mostly identical in the given box model. What do you think is the proper name for that class? Maybe nsRubyContentFrame or something?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It might make sense to use nsRubyTextFrame as the common name, although I'd be ok with nsRubyContentFrame.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

We probably need to implement this before implementing inter-character ruby.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch 1 - Parse and compute ruby-align

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch 2 - Move some code to an independent method for reuse

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch 3 - Adjust gap assigning algorithm

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch 4 - Expand ruby boxes in respect to ruby-align

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch 5 - Reftests

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8564792 [details] [diff] [review]
patch 1 - Parse and compute ruby-align

Review of attachment 8564792 [details] [diff] [review]:
-----------------------------------------------------------------

Better get someone else to review style system patches :-)

Comment 11

[Cameron McCormack (:heycam)]

Comment on attachment 8564792 [details] [diff] [review]
patch 1 - Parse and compute ruby-align

Review of attachment 8564792 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsComputedDOMStyle.cpp
@@ +3077,5 @@
>  
>  CSSValue*
> +nsComputedDOMStyle::DoGetRubyAlign()
> +{
> +  nsROCSSPrimitiveValue *val = new nsROCSSPrimitiveValue;

"*" next to type please.

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc77e298febd

Comment 13

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/25727d649887
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f463490055c
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a4062a1ebfe
https://hg.mozilla.org/integration/mozilla-inbound/rev/309115dcfc7f
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3d40211baa5

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25727d649887
https://hg.mozilla.org/mozilla-central/rev/3f463490055c
https://hg.mozilla.org/mozilla-central/rev/2a4062a1ebfe
https://hg.mozilla.org/mozilla-central/rev/309115dcfc7f
https://hg.mozilla.org/mozilla-central/rev/a3d40211baa5

Comment 15

[Jean-Yves Perrier [:teoli]]

Documentation has been done:
https://developer.mozilla.org/en-US/docs/Web/CSS/ruby-align
and
https://developer.mozilla.org/en-US/Firefox/Releases/38#CSS