Closed Bug 1133624 Opened 5 years ago Closed 5 years ago

Update default stylesheet for ruby to incude the locale-specific rules

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Depends on 1 open bug, Blocks 1 open bug, )

Details

Attachments

(1 file)

The default stylesheet in CSS Ruby spec has been updated to include two locale-specific rules, we should include them.
We should be careful about whether they're actually efficient.
Depends on: 1134947
Attached patch patchSplinter Review
Assignee: nobody → quanxunzhen
Attachment #8569502 - Flags: review?(dholbert)
Do you know what dbaron was getting at in comment 1?  (I'm not sure, and I don't want to r+ this without understanding.)

(Alternately, maybe dbaron can chime in, though I think he's afk for a bit, based on his bugzilla nick)
Flags: needinfo?(quanxunzhen)
I admit I'm not sure what he meant. I didn't think there should be any performance problem, so I guessed he was saying we should have test for it to confirm it works as expected.

But after check the code, I guess there is probably some performance problem to have :lang() in html.css, so I think it would be better to have him chime in instead of my guessing here.
Flags: needinfo?(quanxunzhen)
Comment on attachment 8569502 [details] [diff] [review]
patch

OK -- I'm going to punt on this review to dbaron, then, so he can express concerns if he has them.

(I'm also loaded with intern interviews tomorrow & I'm on PTO on Friday, so I probably wouldn't get to this as a legit review until next week anyway.)
Attachment #8569502 - Flags: review?(dholbert) → review?(dbaron)
Comment on attachment 8569502 [details] [diff] [review]
patch

I'm not worried about the performance because all of the selectors have an "rt" or "rtc" element selector in the rightmost part-between-combinators.

It might be good to also have a test that ruby-align: center and ruby-align: space-around produce different results, if we don't have that already.

r=dbaron with that
Attachment #8569502 - Flags: review?(dbaron) → review+
If you meant in normal cases, then we have had a test to check the behavior of different values of ruby-align in bug 1055676.
https://hg.mozilla.org/mozilla-central/rev/38f11ce2749a
https://hg.mozilla.org/mozilla-central/rev/bc9a6c293737
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.