1055679 - Moztest's unittest adapter should log stacks and messages separately

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

This will make formatting in a tbpl starrable way less brittle and make marionette's special formatter obsolete.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Try (seeded failures): 

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=71f776088afb

I think I'm ending up with too many newlines somewhere.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Include exception stacks in test_end actions in mozlog's formatters.

This makes the tbpl and mach formatters include stacks in test_end.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Log a message and stack seperately in mozlog.

This modifies the unittest adapter to log messages and stack seperately. The traceback api is a little cryptic, but this seems to produce the expected output.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: Remove marionette's ad hoc log formatter now that it's no longer needed.

Finally, this removes the one off formatter from marionette altogether.

Comment 5

[James Graham [:jgraham]]

This looks good to me. I briefly looked at the output in treeherder and it seemed OK, but I assume you will post a corrected patch if you spot any problems I missed.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Attachment: Log stacks and messages separately in moztest's unittest adapter and include stacks in mozlog's test_end.

This is the mozlog/moztest patches folded together, the marionette part is unchanged and might need to land after. Two details I noticed and fixed:

I was missing the "Traceback (most recent call last):" header we all know and love.
The idea of putting the message before the stacktrace is specific to the tbplformatter, the stack before the message gets us what I think we want in the machformatter.

The treeherder output looked mostly fine before, but here's a before/after for good measure:

Before: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8f25c9674672
After: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c175c76d9bee

Comment 7

[Chris Manchester (limited bugmail, email directly)]

The moztest/mozlog changes:

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa5716c4f18e

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fa5716c4f18e

Comment 9

[Chris Manchester (limited bugmail, email directly)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb09f73f2582

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eb09f73f2582