1055771 - Search suggestions for old query appear when activity is re-launched

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[:Margaret Leibovic]

Maybe this is a regression from bug 1052563.

Comment 1

[:Margaret Leibovic]

Attachment: Reset search suggestions when activity is launched from a new intent

We don't update suggestions when the text changes if the search bar isn't active. So in order to reset the suggestions we need to make sure to activate editing mode before resetting the query.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8475514 [details] [diff] [review]
Reset search suggestions when activity is launched from a new intent

Review of attachment 8475514 [details] [diff] [review]:
-----------------------------------------------------------------

I would probably make that comment a little more strongly worded. i.e. Something like "Suggestions won't update if we're not in edit mode." makes it clearer to me than "Reset the query after entering edit mode to update the suggestions appropriately."

Comment 3

[:Margaret Leibovic]

(In reply to Wesley Johnston (:wesj) from comment #2)
> Comment on attachment 8475514 [details] [diff] [review]
> Reset search suggestions when activity is launched from a new intent
> 
> Review of attachment 8475514 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I would probably make that comment a little more strongly worded. i.e.
> Something like "Suggestions won't update if we're not in edit mode." makes
> it clearer to me than "Reset the query after entering edit mode to update
> the suggestions appropriately."

Yeah, I don't love the way things like this are coupled right now :(

I also thought about making an explicit clearSuggestions method on SuggestionsFragment. Maybe that would be a better solution.

Comment 4

[:Margaret Leibovic]

Attachment: Reset search suggestions when activity is launched from a new intent

Updated the comment to be more explicit about the ordering.

Also, I looked into the logic for SuggestClient, and we don't perform a network request when there's an empty query; we just return an empty suggestion list. So I don't feel as bad about making this flow through the loadSuggestions code path.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/0654c821911a
https://github.com/mozilla/fennec-search/commit/b41d8feed71873960c8ac389fead9e2f66c7969f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0654c821911a