1055779 - Improve Fake H2.64 GMP plugin to better exercise GMP/platform/packetization code

Status: RESOLVED INCOMPLETE

(Core :: Audio/Video: GMP, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

The ideal fake plugin would generate SPS/PPS "NALs", would generate encoded data that approximated (with random noise) the bitrate requested, and generate multiple NALs if the data doesn't fit in the max encoded NAL size passed in (i.e. support mode 0), and send "IDRs" at apropriate times.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

I would not block on this.  I would uplift when possible as it's test-only changes.

Comment 2

[Benjamin Smedberg]

I'm closing a lot of bugs which are filed as Adobe Flash bugs which are either irrelevant, not actionable, or not serious enough to track in the Mozilla bug tracker. For the most part, Flash bugs should be filed in Adobe bugbase, and we'll only track a few highly-critical issues in the Mozilla tracker.

Comment 3

[Nils Ohlmeier [:drno]]

Sorry this bug is not related to Flash at all. This is about improving the fake GMP plugin which is used in our CI systems, because of the unavailability of Cisco's OpenH264 plugin in CI.

And I think we still might want this, although I guess Dan should make this call these days :-)

Comment 4

[Dan Minor [:dminor]]

I think this is worth keeping until we've had a chance to review our automation requirements (which is happening this quarter).

Comment 5

[Marco Castelluccio [:marco]]

It's been a while, is it still worth keeping this bug open?

Comment 6

[Dan Minor [:dminor]]

We added SPS/PPS as part of Bug 1376873. The other relevant part is covered by Bug 1509012. We also have Bug 1462786 to switch to using the real openh264 encoder when possible. So I think it's safe to close this now.